[TODO] at76c50x: remove wext includes

[TODO] at76c50x: remove wext includes

[Johannes Berg]

Not possible right now:
at76c50x-usb.h:404:11: error: ‘IW_ESSID_MAX_SIZE’ undeclared here (not in a function)
at76c50x-usb.c: In function ‘at76_startup_device’:
at76c50x-usb.c:1371:263: error: ‘IW_MODE_ADHOC’ undeclared (first use in this function)
at76c50x-usb.c:1371:263: note: each undeclared identifier is reported only once for each function it appears in
at76c50x-usb.c: In function ‘at76_add_interface’:
at76c50x-usb.c:1863:19: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
at76c50x-usb.c: In function ‘at76_init_new_device’:
at76c50x-usb.c:2269:18: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)

but none of those constants should be used in a mac80211 driver.

Also this driver is missing a MAINTAINERS entry.

Cc: Kalle Valo <kalle.valo@iki.fi>
---
 drivers/net/wireless/at76c50x-usb.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/net/wireless/at76c50x-usb.c	2011-07-13 10:09:37.000000000 +0200
+++ b/drivers/net/wireless/at76c50x-usb.c	2011-07-13 10:09:40.000000000 +0200
@@ -38,8 +38,6 @@
 #include <linux/if_arp.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
-#include <linux/wireless.h>
-#include <net/iw_handler.h>
 #include <net/ieee80211_radiotap.h>
 #include <linux/firmware.h>
 #include <linux/leds.h>

Re: [TODO] at76c50x: remove wext includes

[Kalle Valo]

On 07/13/2011 11:47 AM, Johannes Berg wrote:
> Not possible right now:
> at76c50x-usb.h:404:11: error: ‘IW_ESSID_MAX_SIZE’ undeclared here (not in a function)
> at76c50x-usb.c: In function ‘at76_startup_device’:
> at76c50x-usb.c:1371:263: error: ‘IW_MODE_ADHOC’ undeclared (first use in this function)
> at76c50x-usb.c:1371:263: note: each undeclared identifier is reported only once for each function it appears in
> at76c50x-usb.c: In function ‘at76_add_interface’:
> at76c50x-usb.c:1863:19: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
> at76c50x-usb.c: In function ‘at76_init_new_device’:
> at76c50x-usb.c:2269:18: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
> 
> but none of those constants should be used in a mac80211 driver.
> 
> Also this driver is missing a MAINTAINERS entry.

The driver has been broken due to the mac80211 changes for a long time
and it's obvious that I can't maintain it anymore as I haven't touched
it for a long time. I would like to just remove it altogether. Any
objections?

If someone wants to step up and fix it, now is the time to do it.

Kalle

Re: [TODO] at76c50x: remove wext includes

[Julian Calaby]

On Wed, Jul 13, 2011 at 18:52, Kalle Valo <kvalo@adurom.com> wrote:
> The driver has been broken due to the mac80211 changes for a long time
> and it's obvious that I can't maintain it anymore as I haven't touched
> it for a long time. I would like to just remove it altogether. Any
> objections?

What hardware is it for?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

Re: [TODO] at76c50x: remove wext includes

[Kalle Valo]

On 07/13/2011 01:35 PM, Julian Calaby wrote:
> On Wed, Jul 13, 2011 at 18:52, Kalle Valo <kvalo@adurom.com> wrote:
>> The driver has been broken due to the mac80211 changes for a long time
>> and it's obvious that I can't maintain it anymore as I haven't touched
>> it for a long time. I would like to just remove it altogether. Any
>> objections?
> 
> What hardware is it for?

For USB devices from stone age which had Atmel at76c50x chipset. For
example Belkin F5D5060 was one of them:

http://www.gearxs.com/gearxs/product_info.php?products_id=3535

Kalle

Re: [TODO] at76c50x: remove wext includes

[Julian Calaby]

On Wed, Jul 13, 2011 at 20:50, Kalle Valo <kvalo@adurom.com> wrote:
> On 07/13/2011 01:35 PM, Julian Calaby wrote:
>> On Wed, Jul 13, 2011 at 18:52, Kalle Valo <kvalo@adurom.com> wrote:
>>> The driver has been broken due to the mac80211 changes for a long time
>>> and it's obvious that I can't maintain it anymore as I haven't touched
>>> it for a long time. I would like to just remove it altogether. Any
>>> objections?
>>
>> What hardware is it for?
>
> For USB devices from stone age which had Atmel at76c50x chipset. For
> example Belkin F5D5060 was one of them:
>
> http://www.gearxs.com/gearxs/product_info.php?products_id=3535

Thanks!

I found the device table in the driver which helpfully lists
manufacturers and model numbers, of all of those, the only ones I can
obtain on eBay are the Linksys ones and the Netgear ones - which means
I've probably got a really small chance of laying hands on one of
these chipsets as they both like to recycle model numbers.

I'll see what I can get locally and maybe pick this up if I find anything.

Until then, you might as well drop it from the kernel if nobody else
shows up - if I find anything I'll restore it from the history. (that
said, I *really* need another project at the moment =) )

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

Re: [TODO] at76c50x: remove wext includes

[Pavel Roskin]

On 07/13/2011 04:52 AM, Kalle Valo wrote:
> On 07/13/2011 11:47 AM, Johannes Berg wrote:
>> Not possible right now:
>> at76c50x-usb.h:404:11: error: ‘IW_ESSID_MAX_SIZE’ undeclared here (not in a function)
>> at76c50x-usb.c: In function ‘at76_startup_device’:
>> at76c50x-usb.c:1371:263: error: ‘IW_MODE_ADHOC’ undeclared (first use in this function)
>> at76c50x-usb.c:1371:263: note: each undeclared identifier is reported only once for each function it appears in
>> at76c50x-usb.c: In function ‘at76_add_interface’:
>> at76c50x-usb.c:1863:19: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
>> at76c50x-usb.c: In function ‘at76_init_new_device’:
>> at76c50x-usb.c:2269:18: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
>>
>> but none of those constants should be used in a mac80211 driver.
>>
>> Also this driver is missing a MAINTAINERS entry.
>
> The driver has been broken due to the mac80211 changes for a long time
> and it's obvious that I can't maintain it anymore as I haven't touched
> it for a long time. I would like to just remove it altogether. Any
> objections?
>
> If someone wants to step up and fix it, now is the time to do it.

Please keep the driver for now!  I have a pile of compatible hardware, 
and I should be able to fix it.  I'm placing it onto my TODO list.

There is some really obsolete hardware that we may need to stop 
supporting, e.g. Atheros AR5210, but the reason is because it's 
supported by an actively developed driver, ath5k, and the AR5210 code 
stands in the way all the time.

However, at76c50x-usb is a separate driver and it doesn't stand in the 
way of anybody except when global changes are made.

-- 
Regards,
Pavel Roskin

Re: [TODO] at76c50x: remove wext includes

[Kalle Valo]

Pavel Roskin <proski@gnu.org> writes:

> On 07/13/2011 04:52 AM, Kalle Valo wrote:
>> The driver has been broken due to the mac80211 changes for a long time
>> and it's obvious that I can't maintain it anymore as I haven't touched
>> it for a long time. I would like to just remove it altogether. Any
>> objections?
>>
>> If someone wants to step up and fix it, now is the time to do it.
>
> Please keep the driver for now!

Ok, I won't remove it now but I'll send a patch stating that it's
broken currently.

> I have a pile of compatible hardware, and I should be able to fix
> it. I'm placing it onto my TODO list.

Nice. Thank you for stepping in.

> There is some really obsolete hardware that we may need to stop
> supporting, e.g. Atheros AR5210, but the reason is because it's
> supported by an actively developed driver, ath5k, and the AR5210 code
> stands in the way all the time.
>
> However, at76c50x-usb is a separate driver and it doesn't stand in the
> way of anybody except when global changes are made.

You are right. The problem is that the driver is broken currently as
it requires bssid before authentication and mac80211 doesn't provide
it. Or at least I haven't found a way to do that.

I know that Johannes has been talking about adding support for
providing bssid to the driver before authentication. So there is a
chance that we might be able to fix this without major hacks.

-- 
Kalle Valo