From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: "mcgrof@gmail.com" <mcgrof@gmail.com>,
"lrodriguez@atheros.com" <lrodriguez@atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] compat-wireless: deactivate sido suspend for brcmfmac on older kernels.
Date: Tue, 19 Jul 2011 12:29:00 +0200 [thread overview]
Message-ID: <4E255C6C.50507@broadcom.com> (raw)
In-Reply-To: <1311010573-17015-1-git-send-email-hauke@hauke-m.de>
On 07/18/2011 07:36 PM, Hauke Mehrtens wrote:
> With this patch the build does not break any more because of this commit:
>
> commit da68c4eb258cd9f3f0b8aeb7e46b8118bb6358b6
> Author: Nicolas Pitre<nico@fluxnic.net>
> Date: Fri Mar 5 13:43:31 2010 -0800
>
> sdio: introduce API for special power management features
>
> This build error occurs without the patch on linux-2.6.32.
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c: In function ‘brcmf_sdio_suspend’:
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1087:2: error: ‘mmc_pm_flag_t’ undeclared (first use in this function)
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1087:2: note: each undeclared identifier is reported only once for each function it appears in
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1087:16: error: expected ‘;’ before ‘sdio_flags’
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1088:2: warning: ISO C90 forbids mixed declarations and code
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1092:2: error: ‘sdio_flags’ undeclared (first use in this function)
> /drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c:1092:2: error: implicit declaration of function ‘sdio_get_host_pm_caps’
>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> ---
Thanks, Hauke
That clarifies it.
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
next prev parent reply other threads:[~2011-07-19 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 20:57 [PATCH 1/2] compat-wireless: add some new config options for b43 Hauke Mehrtens
2011-07-17 20:57 ` [PATCH 2/2] compat-wireless: deactivate sido suspend for brcmfmac on older kernels Hauke Mehrtens
2011-07-18 10:42 ` Arend van Spriel
2011-07-18 17:36 ` [PATCH v2 " Hauke Mehrtens
2011-07-19 10:29 ` Arend van Spriel [this message]
2011-07-20 1:11 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E255C6C.50507@broadcom.com \
--to=arend@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).