[PATCH 1/2] b43legacy: report core number

[PATCH 1/2] b43legacy: report core number

[Pavel Roskin]

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 0 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
index ffa4671..224991a 100644
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -3785,7 +3785,8 @@ static int b43legacy_wireless_init(struct ssb_device *dev)
 	INIT_WORK(&wl->beacon_update_trigger, b43legacy_beacon_update_trigger_work);
 
 	ssb_set_devtypedata(dev, wl);
-	b43legacyinfo(wl, "Broadcom %04X WLAN found\n", dev->bus->chip_id);
+	b43legacyinfo(wl, "Broadcom %04X WLAN found (core revision %u)\n",
+		      dev->bus->chip_id, dev->id.revision);
 	err = 0;
 out:
 	return err;

[PATCH 2/2] b43legacy: remove asm/atomic.h includes as suggested by checkpatch.pl

[Pavel Roskin]

Including linux/atomic.h doesn't appear to be necessary.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 0 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/b43legacy.h b/drivers/net/wireless/b43legacy/b43legacy.h
index 17a130d..71159aa 100644
--- a/drivers/net/wireless/b43legacy/b43legacy.h
+++ b/drivers/net/wireless/b43legacy/b43legacy.h
@@ -8,7 +8,6 @@
 #include <linux/stringify.h>
 #include <linux/netdevice.h>
 #include <linux/pci.h>
-#include <asm/atomic.h>
 #include <linux/io.h>
 
 #include <linux/ssb/ssb.h>
diff --git a/drivers/net/wireless/b43legacy/dma.h b/drivers/net/wireless/b43legacy/dma.h
index 04121ff..7ed84b9 100644
--- a/drivers/net/wireless/b43legacy/dma.h
+++ b/drivers/net/wireless/b43legacy/dma.h
@@ -5,7 +5,6 @@
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
 #include <linux/linkage.h>
-#include <asm/atomic.h>
 
 #include "b43legacy.h"
 

Re: [PATCH 2/2] b43legacy: remove asm/atomic.h includes as suggested by checkpatch.pl

[Larry Finger]

On 07/26/2011 10:36 AM, Pavel Roskin wrote:
> Including linux/atomic.h doesn't appear to be necessary.
>
> Signed-off-by: Pavel Roskin<proski@gnu.org>

As b43 manages to also do atomic operations without this header, this patch 
should be OK for all architectures.

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>

Re: [PATCH 1/2] b43legacy: report core number

[Larry Finger]

On 07/26/2011 10:36 AM, Pavel Roskin wrote:
> Signed-off-by: Pavel Roskin<proski@gnu.org>
> ---
>   0 files changed, 0 insertions(+), 0 deletions(-)

Very informative diffstat! :)

>
> diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
> index ffa4671..224991a 100644
> --- a/drivers/net/wireless/b43legacy/main.c
> +++ b/drivers/net/wireless/b43legacy/main.c
> @@ -3785,7 +3785,8 @@ static int b43legacy_wireless_init(struct ssb_device *dev)
>   	INIT_WORK(&wl->beacon_update_trigger, b43legacy_beacon_update_trigger_work);
>
>   	ssb_set_devtypedata(dev, wl);
> -	b43legacyinfo(wl, "Broadcom %04X WLAN found\n", dev->bus->chip_id);
> +	b43legacyinfo(wl, "Broadcom %04X WLAN found (core revision %u)\n",
> +		      dev->bus->chip_id, dev->id.revision);
>   	err = 0;
>   out:
>   	return err;

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>

Re: [PATCH 1/2] b43legacy: report core number

[Pavel Roskin]

On 07/26/2011 11:57 AM, Larry Finger wrote:
> On 07/26/2011 10:36 AM, Pavel Roskin wrote:
>> Signed-off-by: Pavel Roskin<proski@gnu.org>
>> ---
>> 0 files changed, 0 insertions(+), 0 deletions(-)
>
> Very informative diffstat! :)

That happens if "stg mail" is run from a directory that is not above the 
changed files.  I'll try to get it fixed.

Thanks for the quick review!

-- 
Regards,
Pavel Roskin

Re: [PATCH 1/2] b43legacy: report core number

[Kalle Valo]

Pavel Roskin <proski@gnu.org> writes:

>>> 0 files changed, 0 insertions(+), 0 deletions(-)
>>
>> Very informative diffstat! :)
>
> That happens if "stg mail" is run from a directory that is not above
> the changed files.  I'll try to get it fixed.

Is stgit still alive? I haven't seen a release for a long time.

-- 
Kalle Valo

Re: [PATCH 1/2] b43legacy: report core number

[Pavel Roskin]

On 08/03/2011 11:55 AM, Kalle Valo wrote:
> Pavel Roskin<proski@gnu.org>  writes:
>
>>>> 0 files changed, 0 insertions(+), 0 deletions(-)
>>>
>>> Very informative diffstat! :)
>>
>> That happens if "stg mail" is run from a directory that is not above
>> the changed files.  I'll try to get it fixed.
>
> Is stgit still alive? I haven't seen a release for a long time.

I hate to go too far offtopic, but anyway, StGIT is pretty much usable, 
even though it's not under active development anymore.

-- 
Regards,
Pavel Roskin