linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, hostap@lists.shmoo.com
Subject: Re: mac80211 + hostapd: EAPOL frames rate selection
Date: Fri, 29 Jul 2011 20:05:17 +0200	[thread overview]
Message-ID: <4E32F65D.6030703@openwrt.org> (raw)
In-Reply-To: <CAGXE3d9Ww4qXr23C-GK=a33M_nuesLU+N-J=+-AZWz7CAVK6hA@mail.gmail.com>

On 2011-07-29 7:55 PM, Helmut Schaa wrote:
> On Fri, Jul 29, 2011 at 7:37 PM, Jouni Malinen<j@w1.fi>  wrote:
>>  On Fri, Jul 29, 2011 at 11:14:20AM +0200, Helmut Schaa wrote:
>>>  I just noticed that EAPOL frames generated by hostapd during the 4-way
>>>  handshake are sent out by mac80211 using a rate as selected by the rc
>>>  algorithm for data frames. In my case minstrel_ht selects a MCS rate for
>>>  11n clients which sometimes results in a 4-way handshake timeout under
>>>  low signal conditions.
>>
>>  That sounds like an issue that should be fixed in the rate control
>>  algorithm if it is indeed using unsuitable rate immediately after
>>  association. Dropping data frames completely is not really a good thing
>>  regardless of whether they are EAPOL packets or not..
>
> True. Nevertheless other drivers like madwifi or the ralink legacy drivers also
> force EAPOL frames to a low rate. That's why I had the idea in the first place.
I think this mainly occurs on devices/drivers that use minstrel_ht, but 
lack proper multi-rate retry. minstrel_ht may pick a high rate for 
probing and on devices with a simple fallback table (e.g. rt2x00), it 
may give up on the frame before having tried a low enough rate.

On ath9k this shouldn't be an issue with minstrel_ht, because it always 
keeps the max_prob_rate in a retry slot.

- Felix


  reply	other threads:[~2011-07-29 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  9:14 mac80211 + hostapd: EAPOL frames rate selection Helmut Schaa
2011-07-29 10:20 ` Mohammed Shafi
2011-07-29 15:17   ` Mohammed Shafi
2011-07-29 15:52     ` Andreas Hartmann
2011-07-29 17:37 ` Jouni Malinen
2011-07-29 17:55   ` Helmut Schaa
2011-07-29 18:05     ` Felix Fietkau [this message]
2012-12-17 17:26       ` Paul Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E32F65D.6030703@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=helmut.schaa@googlemail.com \
    --cc=hostap@lists.shmoo.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).