From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 11/13] ath9k_hw: Disable Walsh spatial spreading for 2 chains
Date: Tue, 02 Aug 2011 19:33:00 +0200 [thread overview]
Message-ID: <4E3834CC.8010001@openwrt.org> (raw)
In-Reply-To: <20110802094610.GA1235@vmraj-lnx.users.atheros.com>
On 2011-08-02 11:46 AM, Rajkumar Manoharan wrote:
> On Fri, Jul 29, 2011 at 02:41:41PM +0200, Felix Fietkau wrote:
>> On 2011-07-29 2:08 PM, Rajkumar Manoharan wrote:
>> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> >---
>> > .../net/wireless/ath/ath9k/ar9003_2p2_initvals.h | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> >diff --git a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
>> >index 2339728..28b44b0 100644
>> >--- a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
>> >+++ b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
>> >@@ -636,7 +636,7 @@ static const u32 ar9300_2p2_baseband_postamble[][5] = {
>> > {0x00009e44, 0x02321e27, 0x02321e27, 0x02291e27, 0x02291e27},
>> > {0x00009e48, 0x5030201a, 0x5030201a, 0x50302012, 0x50302012},
>> > {0x00009fc8, 0x0003f000, 0x0003f000, 0x0001a000, 0x0001a000},
>> >- {0x0000a204, 0x000037c0, 0x000037c4, 0x000037c4, 0x000037c0},
>> >+ {0x0000a204, 0x000036c0, 0x000036c4, 0x000036c4, 0x000036c0},
>> > {0x0000a208, 0x00000104, 0x00000104, 0x00000004, 0x00000004},
>> > {0x0000a22c, 0x01026a2f, 0x01026a2f, 0x01026a2f, 0x01026a2f},
>> > {0x0000a230, 0x0000000a, 0x00000014, 0x00000016, 0x0000000b},
>> That patch makes no sense, it disables Walsh spatial spreading in
>> the initvals, but the driver still enables it in
>> ar9003_hw_set_channel_regs.
>> By the way, why should we disable Walsh spatial spreading?
>>
> The initval table is filled with default values recommended in register spec.
> This patch does that. And these default value can be altered during chip bringup
> based on chip family.
OK, then the patch description should probably mention that this change
has no effect and does not actually disable this feature in general,
since the driver unconditionally enables it elsewhere.
- Felix
next prev parent reply other threads:[~2011-08-02 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 12:08 [PATCH v2 01/13] ath9k_hw: Add dump_eeprom support for AR9003 Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 02/13] ath9k_hw: Add dump_eeprom support for eeprom_4k Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 03/13] ath9k_hw: Add dump_eeprom support for AR9287 Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 04/13] ath9k_hw: Add dump_eeprom support for eeprom_def Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 05/13] ath9k: Dump base eeprom header Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 06/13] ath9k: Dump modal " Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 07/13] ath9k: Remove virtual wiphy specific frame type Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 08/13] ath9k_hw: Fix incorrect Tx control power in AR9003 template Rajkumar Manoharan
2011-08-09 19:51 ` John W. Linville
2011-07-29 12:08 ` [PATCH v2 09/13] ath9k_hw: Optimize rx descriptor processing for AR9003 Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 10/13] ath9k_hw: update PMU to improve ripple issue for AR9485 Rajkumar Manoharan
2011-08-09 19:51 ` John W. Linville
2011-07-29 12:08 ` [PATCH v2 11/13] ath9k_hw: Disable Walsh spatial spreading for 2 chains Rajkumar Manoharan
2011-07-29 12:41 ` Felix Fietkau
2011-08-02 9:46 ` Rajkumar Manoharan
2011-08-02 17:33 ` Felix Fietkau [this message]
2011-08-04 17:45 ` Rajkumar Manoharan
2011-08-04 17:55 ` Felix Fietkau
2011-08-15 7:55 ` Rajkumar Manoharan
2011-08-15 18:39 ` John W. Linville
2011-07-29 12:08 ` [PATCH v2 12/13] ath9k_hw: Update the radio parameters related to high_power Rajkumar Manoharan
2011-07-29 12:08 ` [PATCH v2 13/13] ath9k_hw: Update AR9003 high_power tx gain table Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3834CC.8010001@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).