From: Pavel Roskin <proski@gnu.org>
To: Alex Hacker <hacker@epn.ru>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.
Date: Tue, 02 Aug 2011 16:41:07 -0400 [thread overview]
Message-ID: <4E3860E3.20205@gnu.org> (raw)
In-Reply-To: <20110802175024.GG14167@tuxdriver.com>
On 08/02/2011 01:50 PM, John W. Linville wrote:
> On Tue, Aug 02, 2011 at 09:00:34PM +0600, Alex Hacker wrote:
>> ---
>> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Missing Signed-off-by...
And while at that, the subject line is misspelled, which is ironic for a
patch fixing a typo :)
Also, the subject line should be one compact phrase that fits 80
characters (or even shorter). The period at the end is not needed.
Please check the existing git log. Something like this would be fine:
ath9k: typo fix in ar9003_phy.h that may cause incorrect calibration
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2011-08-02 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 15:00 [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process Alex Hacker
2011-08-02 17:50 ` John W. Linville
2011-08-02 20:41 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3860E3.20205@gnu.org \
--to=proski@gnu.org \
--cc=hacker@epn.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).