* [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.
@ 2011-08-02 15:00 Alex Hacker
2011-08-02 17:50 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Alex Hacker @ 2011-08-02 15:00 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Alex Hacker
---
drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
index 6de3f0b..5c59042 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
@@ -850,7 +850,7 @@
#define AR_PHY_TPC_11_B1 (AR_SM1_BASE + 0x220)
#define AR_PHY_PDADC_TAB_1 (AR_SM1_BASE + 0x240)
#define AR_PHY_TX_IQCAL_STATUS_B1 (AR_SM1_BASE + 0x48c)
-#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM_BASE + 0x450 + ((_i) << 2))
+#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM1_BASE + 0x450 + ((_i) << 2))
/*
* Channel 2 Register Map
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.
2011-08-02 15:00 [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process Alex Hacker
@ 2011-08-02 17:50 ` John W. Linville
2011-08-02 20:41 ` Pavel Roskin
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2011-08-02 17:50 UTC (permalink / raw)
To: Alex Hacker; +Cc: linux-wireless
On Tue, Aug 02, 2011 at 09:00:34PM +0600, Alex Hacker wrote:
> ---
> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Missing Signed-off-by...
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> index 6de3f0b..5c59042 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> @@ -850,7 +850,7 @@
> #define AR_PHY_TPC_11_B1 (AR_SM1_BASE + 0x220)
> #define AR_PHY_PDADC_TAB_1 (AR_SM1_BASE + 0x240)
> #define AR_PHY_TX_IQCAL_STATUS_B1 (AR_SM1_BASE + 0x48c)
> -#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM_BASE + 0x450 + ((_i) << 2))
> +#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) (AR_SM1_BASE + 0x450 + ((_i) << 2))
>
> /*
> * Channel 2 Register Map
> --
> 1.7.4
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process.
2011-08-02 17:50 ` John W. Linville
@ 2011-08-02 20:41 ` Pavel Roskin
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Roskin @ 2011-08-02 20:41 UTC (permalink / raw)
To: Alex Hacker; +Cc: John W. Linville, linux-wireless
On 08/02/2011 01:50 PM, John W. Linville wrote:
> On Tue, Aug 02, 2011 at 09:00:34PM +0600, Alex Hacker wrote:
>> ---
>> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Missing Signed-off-by...
And while at that, the subject line is misspelled, which is ironic for a
patch fixing a typo :)
Also, the subject line should be one compact phrase that fits 80
characters (or even shorter). The period at the end is not needed.
Please check the existing git log. Something like this would be fine:
ath9k: typo fix in ar9003_phy.h that may cause incorrect calibration
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-02 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-02 15:00 [PATCH] ath9k: Misprint in ar9003_phy.h. Fix a misprint wich can cause incorrect calibration process Alex Hacker
2011-08-02 17:50 ` John W. Linville
2011-08-02 20:41 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).