From: Larry Finger <Larry.Finger@lwfinger.net>
To: Felix Fietkau <nbd@openwrt.org>,
John W Linville <linville@tuxdriver.com>
Cc: geert@linux-m68k.org, chaoming_li@realsil.com.cn,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Fix build errors on sh4 architecture
Date: Tue, 02 Aug 2011 15:49:42 -0500 [thread overview]
Message-ID: <4E3862E6.508@lwfinger.net> (raw)
In-Reply-To: <4E385BFA.90406@openwrt.org>
On 08/02/2011 03:20 PM, Felix Fietkau wrote:
> On 2011-08-02 9:54 PM, Larry Finger wrote:
>> When rtlwifi is built for the sh4 architecture, build errors of the following
>> type occur. An explicit reference to<linux/io.h> should fix these. I have not
>> setup the cross-build environment, thus this patch is untested on that platform.
>> It does not cause any problems on i386 or x86_64.
>>
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:290: error: implicit
>> declaration of function 'outl': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:295: error: implicit
>> declaration of function 'outb': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:300: error: implicit
>> declaration of function 'inb': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:305: error: implicit
>> declaration of function 'inw': 4 errors in 2 logs
>>
>> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net>
>> Cc: Geert Uytterhoeven<geert@linux-m68k.org>
>> ---
>>
>> John,
>>
>> I'm not sure where this goes. I guess that 3.2 would be OK, unless someone
>> actually tries to build it on sh4. The only time I have seen the errors is
>> in Geert's listing of errors and warnings.
> I looked at the code that uses raw port access, and it looks to me like this is
> just a bunch of x86 specific hacks to mess with the ASPM settings of the PCI
> bridge. This code should probably be either #ifdef'd, removed or rewritten. I
> doubt it'll work properly on other architectures.
Thanks Felix.
John,
I'll take another look at this. Please drop the patch.
Larry
prev parent reply other threads:[~2011-08-02 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 19:54 [PATCH] rtlwifi: Fix build errors on sh4 architecture Larry Finger
2011-08-02 20:20 ` Felix Fietkau
2011-08-02 20:49 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3862E6.508@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).