From: Larry Finger <Larry.Finger@lwfinger.net>
To: Franky Lin <frankyl@broadcom.com>
Cc: "Arend van Spriel" <arend@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"gregkh@suse.de" <gregkh@suse.de>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c
Date: Fri, 12 Aug 2011 14:08:32 -0500 [thread overview]
Message-ID: <4E457A30.3010701@lwfinger.net> (raw)
In-Reply-To: <4E45781E.8070508@broadcom.com>
On 08/12/2011 01:59 PM, Franky Lin wrote:
> If you are refering to this line
> >>> + } while ((e = brcmf_deq_event(cfg_priv)));
>
> The extra parentheses are added to fix a compiler warning:
> drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c: In function
> ‘brcmf_event_handler’:
> drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c:3576: warning: suggest
> parentheses around assignment used as truth value
Does checkpatch allow that assignment in the while statement? I would expect it
to want you to
e = brcmf_deq_event(cfg_priv);
} while (e);
Larry
next prev parent reply other threads:[~2011-08-12 19:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 13:34 [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup Arend van Spriel
2011-08-12 13:34 ` [PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c Arend van Spriel
2011-08-12 14:07 ` Rafał Miłecki
2011-08-12 16:44 ` Arend van Spriel
2011-08-12 18:55 ` Arend van Spriel
2011-08-12 18:59 ` Johannes Berg
2011-08-12 18:59 ` Franky Lin
2011-08-12 19:08 ` Larry Finger [this message]
2011-08-12 19:10 ` Arend van Spriel
2011-08-16 20:27 ` Rafał Miłecki
2011-08-12 19:05 ` [PATCHv2 " Arend van Spriel
2011-08-12 19:07 ` Arend van Spriel
2011-08-12 19:09 ` Arend van Spriel
2011-08-16 17:56 ` Dan Carpenter
2011-08-12 13:34 ` [PATCH 02/14] staging: brcm80211: remove iovar IOV_BLOCKSIZE in brcmfmac Arend van Spriel
2011-08-12 14:12 ` Rafał Miłecki
2011-08-12 16:37 ` Arend van Spriel
2011-08-12 20:02 ` Rafał Miłecki
2011-08-12 13:34 ` [PATCH 03/14] staging: brcm80211: remove struct sdioh_info from brcmfmac Arend van Spriel
2011-08-12 13:34 ` [PATCH 04/14] staging: brcm80211: remove global var gInstance " Arend van Spriel
2011-08-12 13:34 ` [PATCH 05/14] staging: brcm80211: remove wext traces in fullmac Arend van Spriel
2011-08-12 13:34 ` [PATCH 06/14] staging: brcm80211: absorb brcmf_sdioh_iovar_op into brcmf_sdcard_iovar_op Arend van Spriel
2011-08-12 13:34 ` [PATCH 07/14] staging: brcm80211: absorb brcmf_sdioh_interrupt_register into brcmf_sdcard_intr_reg Arend van Spriel
2011-08-12 14:31 ` Rafał Miłecki
2011-08-12 13:34 ` [PATCH 08/14] staging: brcm80211: absorb brcmf_sdioh_interrupt_deregister into brcmf_sdcard_intr_dereg Arend van Spriel
2011-08-12 13:34 ` [PATCH 09/14] staging: brcm80211: absorb brcmf_sdioh_abort into brcmf_sdcard_abort Arend van Spriel
2011-08-12 13:34 ` [PATCH 10/14] staging: brcm80211: remove dead code from dhd_sdio.c Arend van Spriel
2011-08-12 13:34 ` [PATCH 11/14] staging: brcm80211: remove wrapper functions in bcmsdh_sdmmc.c Arend van Spriel
2011-08-12 13:34 ` [PATCH 12/14] staging: brcm80211: remove unused parameter from data interface in fullmac Arend van Spriel
2011-08-12 13:35 ` [PATCH 13/14] staging: brcm80211: remove dead SDTEST code from fullmac Arend van Spriel
2011-08-12 13:35 ` [PATCH 14/14] staging: brcm80211: remove unused func parameter in wl_cfg80211 of fullmac Arend van Spriel
2011-08-12 14:02 ` [PATCH 00/14] staging: brcm80211: brcmfmac driver cleanup Rafał Miłecki
2011-08-12 15:14 ` Hauke Mehrtens
2011-08-12 15:43 ` Rafał Miłecki
2011-08-12 16:32 ` Arend van Spriel
2011-08-12 20:04 ` Rafał Miłecki
2011-08-13 7:47 ` Arend van Spriel
2011-08-13 8:30 ` Rafał Miłecki
2011-08-26 9:20 ` Rafał Miłecki
2011-08-26 17:31 ` Henry Ptasinski
2011-08-26 17:38 ` Jason
2011-08-26 17:44 ` Henry Ptasinski
2011-08-26 20:00 ` Jason
2011-08-26 20:15 ` Henry Ptasinski
2011-08-23 20:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E457A30.3010701@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).