Re: [PATCH] rtlwifi: add module parameter to set global debug level

[Stefan Assmann <sassmann@kpanic.de>]

On 12.08.2011 22:33, Larry Finger wrote:
> On 08/12/2011 02:22 PM, Stefan Assmann wrote:
>> Adding a module parameter to allow setting the global debug level.
>> No need to recompile the module anymore to set the debug level.
>>
>> Signed-off-by: Stefan Assmann<sassmann@kpanic.de>
>> ---
>>   drivers/net/wireless/rtlwifi/debug.c |    6 +++++-
>>   1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/debug.c b/drivers/net/wireless/rtlwifi/debug.c
>> index 5fa7385..1d82639 100644
>> --- a/drivers/net/wireless/rtlwifi/debug.c
>> +++ b/drivers/net/wireless/rtlwifi/debug.c
>> @@ -28,12 +28,16 @@
>>
>>   #include "wifi.h"
>>
>> +static unsigned int debug = DBG_EMERG;
>> +module_param(debug, uint, 0);
>> +MODULE_PARM_DESC(debug, "Set global debug level for rtlwifi (uint)");
> 
> As the system puts a (uint) following the description when the modinfo command 
> is used, the one above is redundant. Replace it with (0,2-5) instead. I have no 
> idea why there is a hole in the debug levels, but I hesitate to close it. Also, 
> send patches to John Linville with Cc to wireless.
> 
> Thanks for doing this. I'll sign off on it when you send V2.

Snap, I missed that. Thanks for pointing it out. V2 should be coming
around shortly.

  Stefan