* [PATCH] ath9k: remove a bogus WARN_ON
@ 2011-08-13 16:13 Felix Fietkau
2011-08-15 10:51 ` Stanislaw Gruszka
0 siblings, 1 reply; 3+ messages in thread
From: Felix Fietkau @ 2011-08-13 16:13 UTC (permalink / raw)
To: linux-wireless; +Cc: linville, lrodriguez, sgruszka
On embedded hardware it's normal to not have a PCI device for the PCI
bridge that the wifi card is attached to. pdev->bus->self will be
NULL in that case. In that case, simply return without emitting an
useless kernel stack trace.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
drivers/net/wireless/ath/ath9k/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
index 5685cf1..d8f22aa 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -129,7 +129,7 @@ static void ath_pci_aspm_init(struct ath_common *common)
return;
parent = pdev->bus->self;
- if (WARN_ON(!parent))
+ if (!parent)
return;
pos = pci_pcie_cap(parent);
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: remove a bogus WARN_ON
2011-08-13 16:13 [PATCH] ath9k: remove a bogus WARN_ON Felix Fietkau
@ 2011-08-15 10:51 ` Stanislaw Gruszka
2011-08-20 13:43 ` Felix Fietkau
0 siblings, 1 reply; 3+ messages in thread
From: Stanislaw Gruszka @ 2011-08-15 10:51 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, linville, lrodriguez
On Sat, Aug 13, 2011 at 10:13:49AM -0600, Felix Fietkau wrote:
> On embedded hardware it's normal to not have a PCI device for the PCI
> bridge that the wifi card is attached to. pdev->bus->self will be
> NULL in that case. In that case, simply return without emitting an
> useless kernel stack trace.
Patch is obviously ok, ACK. However I'm not sure if we should not
do anything regarding ASPM. Perhaps there is other way to find out
pcie parent ASPM settings on embedded systems?
Stanislaw
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: remove a bogus WARN_ON
2011-08-15 10:51 ` Stanislaw Gruszka
@ 2011-08-20 13:43 ` Felix Fietkau
0 siblings, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2011-08-20 13:43 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless, linville, lrodriguez
On 2011-08-15 12:51 PM, Stanislaw Gruszka wrote:
> On Sat, Aug 13, 2011 at 10:13:49AM -0600, Felix Fietkau wrote:
>> On embedded hardware it's normal to not have a PCI device for the PCI
>> bridge that the wifi card is attached to. pdev->bus->self will be
>> NULL in that case. In that case, simply return without emitting an
>> useless kernel stack trace.
>
> Patch is obviously ok, ACK. However I'm not sure if we should not
> do anything regarding ASPM. Perhaps there is other way to find out
> pcie parent ASPM settings on embedded systems?
I don't think the embedded system that I'm working on even uses ASPM.
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-20 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-13 16:13 [PATCH] ath9k: remove a bogus WARN_ON Felix Fietkau
2011-08-15 10:51 ` Stanislaw Gruszka
2011-08-20 13:43 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).