From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Michael Büsch" <m@bues.ch>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [RFT][PATCH] b43: use 8K buffers for 64-bit DMA to workaround hardware bug
Date: Wed, 24 Aug 2011 11:53:51 -0500 [thread overview]
Message-ID: <4E552C9F.1020104@lwfinger.net> (raw)
In-Reply-To: <20110824180611.36af5a83@milhouse>
On 08/24/2011 11:06 AM, Michael Büsch wrote:
> On Wed, 24 Aug 2011 17:57:18 +0200
> Rafał Miłecki<zajec5@gmail.com> wrote:
>
>> + /* For unknown reasons - possibly a hardware error - the BCM4311 rev
>> * 02, which uses 64-bit DMA, needs the ring buffer in very low memory,
>> * which accounts for the GFP_DMA flag below.
>> - *
>> - * The flags here must match the flags in free_ringmemory below!
>> */
>> + gfp_t flags = GFP_KERNEL;
>> if (ring->type == B43_DMA_64BIT)
>> flags |= GFP_DMA;
>
>
> Did somebody actually re-evaluate this?
> I still believe that this is not a hardware error, but rather a software
> bug in the DMA allocator that probably is fixed already.
>
> Larry, I think you added this. Do you still have the device that triggered this?
Yes, I do. I'll test the BCM4311 with the GFP_KERNEL flag.
Larry
next prev parent reply other threads:[~2011-08-24 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 15:57 [RFT][PATCH] b43: use 8K buffers for 64-bit DMA to workaround hardware bug Rafał Miłecki
2011-08-24 16:06 ` Michael Büsch
2011-08-24 16:53 ` Larry Finger [this message]
2011-08-26 13:28 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E552C9F.1020104@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).