From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath6kl: Add initial debugfs changes
Date: Wed, 24 Aug 2011 20:31:30 +0300 [thread overview]
Message-ID: <4E553572.2040507@qca.qualcomm.com> (raw)
In-Reply-To: <20110824144644.GD25267@vasanth-laptop>
On 08/24/2011 05:46 PM, Vasanthakumar Thiagarajan wrote:
> On Wed, Aug 24, 2011 at 05:39:48PM +0300, Kalle Valo wrote:
>> On 08/24/2011 05:25 PM, Vasanthakumar Thiagarajan wrote:
>>> +#ifdef CONFIG_ATH6KL_DEBUGFS
>>> +int ath6kl_init_debugfs(struct ath6kl *ar);
>>> +#else
>>> +static inline int ath6kl_init_debugfs(struct ath6kl *ar)
>>> +{
>>> + return 0;
>>> +}
>>> +#endif
>>
>> I would prefer to call this ath6kl_debug_init(). That way we can put all
>> debug initialisation into that, not just debugfs code. And then the
>> ifdef should check for CONFIG_ATH6KL_DEBUG.
>
> May be, but I think we can't always enable debugfs based on only
> CONFIG_ATH6KL_DEBUG as the general debug does not depend on
> CONFIG_DEBUG_FS.
I don't see why we need to check for CONFIG_DEBUG_FS.
debugfs_create_file() should handle the case then CONFIG_DEBUG_FS is
disabled as it will just return ERR_PTR(-ENODEV).
Kalle
next prev parent reply other threads:[~2011-08-24 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 14:25 [PATCH 1/3] ath6kl: Add initial debugfs changes Vasanthakumar Thiagarajan
2011-08-24 14:25 ` [PATCH 2/3] ath6kl: Add debugfs entry to dump target stats Vasanthakumar Thiagarajan
2011-08-24 14:25 ` [PATCH 3/3] ath6kl: Add debugfs file entry to dump credit distribution stats Vasanthakumar Thiagarajan
2011-08-24 14:30 ` [PATCH 1/3] ath6kl: Add initial debugfs changes Vasanthakumar Thiagarajan
2011-08-24 14:33 ` Kalle Valo
2011-08-24 14:44 ` Vasanthakumar Thiagarajan
2011-08-24 17:23 ` Kalle Valo
2011-08-24 14:39 ` Kalle Valo
2011-08-24 14:46 ` Vasanthakumar Thiagarajan
2011-08-24 17:31 ` Kalle Valo [this message]
2011-08-24 14:46 ` Kalle Valo
2011-08-24 14:52 ` Vasanthakumar Thiagarajan
2011-08-24 17:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E553572.2040507@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).