Re: [PATCH 2/2] ath9k_hw: Fix slottime with coverage class

[Felix Fietkau <nbd@openwrt.org>]

On 2011-08-26 5:20 PM, Rajkumar Manoharan wrote:
> On Fri, Aug 26, 2011 at 05:00:04PM +0200, Felix Fietkau wrote:
>>  On 2011-08-26 3:32 PM, Rajkumar Manoharan wrote:
>>  >On Thu, Aug 25, 2011 at 05:36:03PM +0200, Felix Fietkau wrote:
>>  >>  On 2011-08-25 4:45 PM, Rajkumar Manoharan wrote:
>>  >>  >The commit b6ba41bb27eb9810d54e2301355ce56fd0e94a1a updates
>>  >>  >acktimeout wihout updating slottime when coverage class is defined
>>  >>  >as per IEEE 802.11-2007 17.3.8.6.
>>  >>  >
>>  >>  >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>>  >>  I intentionally left the coverage class out of the hw slot time
>>  >>  setting, because increasing slot time too much causes severe
>>  >>  throughput issues. I've observed this even with relatively minor
>>  >>  coverage class settings (e.g. for 2 km) on AR9160 and AR9280. I
>>  >>  haven't tested AR9380 though.
>>  >>
>>  >Which band have you tested on AR9280?
>>  Both.
> IIRC, the scope of section 17 is meant for 5GHz alone. isn't it?
Could be, but it doesn't make much sense to make the coverage class 
setting dependent on 5 GHz. 2.4 GHz is actively being used (also with 
ath9k) for long distance links as well.
The way the coverage class setting is implemented in ath9k at the moment 
works just fine and is tested for both 2.4 GHz and 5 GHz.

- Felix