* [PATCH] ath9k_hw: Set default slottime as 9us
@ 2011-08-27 5:52 Rajkumar Manoharan
2011-08-27 6:27 ` Felix Fietkau
0 siblings, 1 reply; 6+ messages in thread
From: Rajkumar Manoharan @ 2011-08-27 5:52 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Rajkumar Manoharan
Initialize 9us slot time as that is what is used mostly
(for non-ERP cases) and also to be in sync with initvals.
Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 0d7a5ee..05472c5 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -440,7 +440,7 @@ static void ath9k_hw_init_defaults(struct ath_hw *ah)
if (AR_SREV_9100(ah))
ah->sta_id1_defaults |= AR_STA_ID1_AR9100_BA_FIX;
ah->enable_32kHz_clock = DONT_USE_32KHZ;
- ah->slottime = 20;
+ ah->slottime = ATH9K_SLOT_TIME_9;
ah->globaltxtimeout = (u32) -1;
ah->power_mode = ATH9K_PM_UNDEFINED;
}
--
1.7.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Set default slottime as 9us
2011-08-27 5:52 [PATCH] ath9k_hw: Set default slottime as 9us Rajkumar Manoharan
@ 2011-08-27 6:27 ` Felix Fietkau
2011-08-27 6:52 ` Rajkumar Manoharan
0 siblings, 1 reply; 6+ messages in thread
From: Felix Fietkau @ 2011-08-27 6:27 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linville, linux-wireless
On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
> Initialize 9us slot time as that is what is used mostly
> (for non-ERP cases) and also to be in sync with initvals.
>
> Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
Why does it matter, mac80211 tells the driver to reconfigure it anyway.
Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we should
simply remove those.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Set default slottime as 9us
2011-08-27 6:27 ` Felix Fietkau
@ 2011-08-27 6:52 ` Rajkumar Manoharan
2011-08-27 7:04 ` Felix Fietkau
0 siblings, 1 reply; 6+ messages in thread
From: Rajkumar Manoharan @ 2011-08-27 6:52 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linville, linux-wireless
On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
> >Initialize 9us slot time as that is what is used mostly
> >(for non-ERP cases) and also to be in sync with initvals.
> >
> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
> Why does it matter, mac80211 tells the driver to reconfigure it
> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
> should simply remove those.
>
In most of the case, mac80211 set as 9us and also initval uses 9us.
The what is the problem of setting 9us as default. If you want to
remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
it got configured.
--
Rajkumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Set default slottime as 9us
2011-08-27 6:52 ` Rajkumar Manoharan
@ 2011-08-27 7:04 ` Felix Fietkau
2011-08-27 7:09 ` Rajkumar Manoharan
0 siblings, 1 reply; 6+ messages in thread
From: Felix Fietkau @ 2011-08-27 7:04 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linville, linux-wireless
On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote:
> On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
>> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
>> >Initialize 9us slot time as that is what is used mostly
>> >(for non-ERP cases) and also to be in sync with initvals.
>> >
>> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Why does it matter, mac80211 tells the driver to reconfigure it
>> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
>> should simply remove those.
>>
> In most of the case, mac80211 set as 9us and also initval uses 9us.
> The what is the problem of setting 9us as default. If you want to
> remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
> it got configured.
I don't see a problem with the change aside from the fact that it should
not make any difference at all, so I don't really see any point to it.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Set default slottime as 9us
2011-08-27 7:04 ` Felix Fietkau
@ 2011-08-27 7:09 ` Rajkumar Manoharan
2011-08-27 7:14 ` Felix Fietkau
0 siblings, 1 reply; 6+ messages in thread
From: Rajkumar Manoharan @ 2011-08-27 7:09 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linville, linux-wireless
On Sat, Aug 27, 2011 at 09:04:36AM +0200, Felix Fietkau wrote:
> On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote:
> >On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
> >> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
> >> >Initialize 9us slot time as that is what is used mostly
> >> >(for non-ERP cases) and also to be in sync with initvals.
> >> >
> >> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
> >> Why does it matter, mac80211 tells the driver to reconfigure it
> >> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
> >> should simply remove those.
> >>
> >In most of the case, mac80211 set as 9us and also initval uses 9us.
> >The what is the problem of setting 9us as default. If you want to
> >remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
> >it got configured.
> I don't see a problem with the change aside from the fact that it
> should not make any difference at all, so I don't really see any
> point to it.
>
I doubt that using long slottime might affect random backoff. so let it
to be in sync with initval till it is altered. am i right?
--
Rajkumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Set default slottime as 9us
2011-08-27 7:09 ` Rajkumar Manoharan
@ 2011-08-27 7:14 ` Felix Fietkau
0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2011-08-27 7:14 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linville, linux-wireless
On 2011-08-27 9:09 AM, Rajkumar Manoharan wrote:
> On Sat, Aug 27, 2011 at 09:04:36AM +0200, Felix Fietkau wrote:
>> On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote:
>> >On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
>> >> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
>> >> >Initialize 9us slot time as that is what is used mostly
>> >> >(for non-ERP cases) and also to be in sync with initvals.
>> >> >
>> >> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> >> Why does it matter, mac80211 tells the driver to reconfigure it
>> >> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
>> >> should simply remove those.
>> >>
>> >In most of the case, mac80211 set as 9us and also initval uses 9us.
>> >The what is the problem of setting 9us as default. If you want to
>> >remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
>> >it got configured.
>> I don't see a problem with the change aside from the fact that it
>> should not make any difference at all, so I don't really see any
>> point to it.
>>
> I doubt that using long slottime might affect random backoff. so let it
> to be in sync with initval till it is altered. am i right?
If you want to get this change in, I don't care. I'm just saying it
doesn't get left at the default long enough for it to matter in any way.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-27 7:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-27 5:52 [PATCH] ath9k_hw: Set default slottime as 9us Rajkumar Manoharan
2011-08-27 6:27 ` Felix Fietkau
2011-08-27 6:52 ` Rajkumar Manoharan
2011-08-27 7:04 ` Felix Fietkau
2011-08-27 7:09 ` Rajkumar Manoharan
2011-08-27 7:14 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).