From: Greg Dietsche <gregory.dietsche@cuw.edu>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start
Date: Mon, 29 Aug 2011 08:33:39 -0500 [thread overview]
Message-ID: <4E5B9533.6000109@cuw.edu> (raw)
In-Reply-To: <20110829122013.GA3597@redhat.com>
Hi Stanislaw,
On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote:
> On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote:
>
>> This message should be a debug message and not a warning. So
>> change it from IWL_WARN to IWL_DEBUG_HT.
>>
> I'm currently doing massive iwlegacy driver cleanup. Would be easier
> for me to apply these patches on top of my changes instead of rebase
> my patches. I will queue these two patches and post them together with
> my pending patches.
>
>
That sounds good to me. I have the 4065 card in my laptop and want to
learn how it works. If you want someone to test your changes, I'm willing.
I have six other patches that are trivial in nature for the iwlegacy
driver. One of those also applies to the iwlagn driver, so seven patches
in total. They remove some null checks that aren't necessary and also
cleanup a few unused variables. There are two patches in the set that
I'm not 100% sure about. They remove null checks and I haven't been able
to prove to myself that they are correct. However, if they aren't
correct, then there are some null checks in other places that need to be
added....
Anyway, I can hold off on these until you've done your cleanup and see
what still applies, or if you have a tree someplace, I'd be happy to
rebase them for you. I've been running them on my laptop for a few days
now with no problems.
Thanks,
Greg
next prev parent reply other threads:[~2011-08-29 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 13:26 [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start Greg Dietsche
2011-08-28 13:26 ` [PATCH 2/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_rs_tl_turn_on_agg_for_tid Greg Dietsche
2011-08-28 13:32 ` [PATCH 2/2 v2] iwlegacy: change IWL_ERR " y
2011-08-29 12:20 ` [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start Stanislaw Gruszka
2011-08-29 13:33 ` Greg Dietsche [this message]
2011-08-29 14:00 ` Stanislaw Gruszka
2011-09-06 15:01 ` Stanislaw Gruszka
2011-09-08 3:51 ` Greg Dietsche
2011-09-08 16:11 ` Stanislaw Gruszka
2011-09-18 14:41 ` Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B9533.6000109@cuw.edu \
--to=gregory.dietsche@cuw.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).