linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Raja Mani <rmani@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: <kvalo@qca.qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/20] ath6kl: Add functionality for starting AP mode
Date: Tue, 30 Aug 2011 11:17:43 +0530	[thread overview]
Message-ID: <4E5C797F.3090900@qca.qualcomm.com> (raw)
In-Reply-To: <1314620641-24257-2-git-send-email-jouni@qca.qualcomm.com>

On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:
> Use cfg80211 add/del_beacon callbacks for starting/stopping AP mode and
> set_beacon to update AP configuration (mainly, to update Beacon and
> Probe Response IEs).
>
> Signed-off-by: Jouni Malinen<jouni@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath6kl/cfg80211.c |  176 ++++++++++++++++++++++++++++
>   drivers/net/wireless/ath/ath6kl/core.h     |    2 +
>   drivers/net/wireless/ath/ath6kl/wmi.c      |   46 +++++++
>   drivers/net/wireless/ath/ath6kl/wmi.h      |   20 +++
>   4 files changed, 244 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index 9128aa3..e486c1c 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -1435,6 +1435,178 @@ static int ar6k_cfg80211_suspend(struct wiphy *wiphy,
>   }
>   #endif
>
> +static int ath6kl_set_channel(struct wiphy *wiphy, struct net_device *dev,
> +			      struct ieee80211_channel *chan,
> +			      enum nl80211_channel_type channel_type)
> +{
> +	struct ath6kl *ar = ath6kl_priv(dev);
> +
> +	if (!test_bit(WLAN_ENABLED,&ar->flag)) {
> +		ath6kl_err("%s: wlan disabled\n", __func__);
> +		return -EIO;
> +	}
> +
> +	ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "%s: center_freq=%u hw_value=%u\n",
> +		   __func__, chan->center_freq, chan->hw_value);
> +	ar->next_chan = chan->center_freq;
> +
> +	return 0;
> +}
> +
> +static int ath6kl_ap_beacon(struct wiphy *wiphy, struct net_device *dev,
> +			    struct beacon_parameters *info, bool add)
> +{
> +	struct ath6kl *ar = ath6kl_priv(dev);
> +	struct ieee80211_mgmt *mgmt;
> +	u8 *ies;
> +	int ies_len;
> +	struct wmi_connect_cmd p;
> +	int i;
> +
> +	ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "%s: add=%d\n", __func__, add);
> +
> +	if (!test_bit(WMI_READY,&ar->flag))
> +		return -EIO;
> +
> +	if (!test_bit(WLAN_ENABLED,&ar->flag))
> +		return -EIO;

How about calling ath6kl_cfg80211_ready() function to check WMI_READY 
and WLAN_ENABLED status ?

> +
> +	if (ar->next_mode != AP_NETWORK)
> +		return -EOPNOTSUPP;
> +
> +	if (info->beacon_ies&&
> +	    ath6kl_wmi_set_appie_cmd(ar->wmi, WMI_FRAME_BEACON,
> +				     info->beacon_ies, info->beacon_ies_len))
> +		return -EIO;
[..]

  reply	other threads:[~2011-08-30  5:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 12:23 [PATCH 00/20] ath6kl: AP mode and P2P Jouni Malinen
2011-08-29 12:23 ` [PATCH 01/20] ath6kl: Add functionality for starting AP mode Jouni Malinen
2011-08-30  5:47   ` Raja Mani [this message]
2011-08-30  8:40     ` Jouni Malinen
2011-08-30  8:49       ` Kalle Valo
2011-08-30 10:38         ` Jouni Malinen
2011-08-30  9:10       ` Raja Mani
2011-08-30  9:02   ` Kalle Valo
2011-08-30 14:03     ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 02/20] ath6kl: Fix AP mode (Re)AssocReq IE processing Jouni Malinen
2011-08-29 12:23 ` [PATCH 03/20] ath6kl: Delay initial group key setup in AP mode Jouni Malinen
2011-08-29 12:23 ` [PATCH 04/20] ath6kl: Use change_station() to authorize/unauthorize STAs Jouni Malinen
2011-08-30  9:06   ` Kalle Valo
2011-08-30 14:09     ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 05/20] ath6kl: Add new WMI commands and events for P2P Jouni Malinen
2011-08-29 12:23 ` [PATCH 06/20] ath6kl: Implement remain_on_channel and cancel_remain_on_channel Jouni Malinen
2011-08-29 12:23 ` [PATCH 07/20] ath6kl: Implement mgmt_tx Jouni Malinen
2011-08-30  9:23   ` Kalle Valo
2011-08-30 14:13     ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 08/20] ath6kl: Request P2P capabilities during target init Jouni Malinen
2011-08-30  9:51   ` Raja Mani
2011-08-30 14:30     ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 09/20] ath6kl: Add cfg80211 calls for remain-on-channel events Jouni Malinen
2011-08-29 12:23 ` [PATCH 10/20] ath6kl: Use set_appie command to add Probe Request IEs Jouni Malinen
2011-08-30  9:26   ` Kalle Valo
2011-08-30 14:16     ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 11/20] ath6kl: Support channel set request for startscan command Jouni Malinen
2011-08-30  9:33   ` Kalle Valo
2011-08-30  9:51     ` Vasanthakumar Thiagarajan
2011-08-30 11:45       ` Vasanthakumar Thiagarajan
2011-08-30 14:44     ` Jouni Malinen
2011-08-30 10:04   ` Raja Mani
2011-08-30 10:30     ` Kalle Valo
2011-08-30 10:33       ` Raja Mani
2011-08-29 12:23 ` [PATCH 12/20] ath6kl: Report received Probe Request frames to cfg80211 Jouni Malinen
2011-08-29 12:23 ` [PATCH 13/20] ath6kl: Notify cfg80211 of TX status of mgmt_tx frames Jouni Malinen
2011-08-29 12:23 ` [PATCH 14/20] ath6kl: Report received Action frames to cfg80211 Jouni Malinen
2011-08-29 12:23 ` [PATCH 15/20] ath6kl: Advertise supported mgmt_stypes Jouni Malinen
2011-08-29 12:23 ` [PATCH 16/20] ath6kl: Add support for new P2P iftypes in mode changes Jouni Malinen
2011-08-29 12:23 ` [PATCH 17/20] ath6kl: Fix a typo in ath6k context Jouni Malinen
2011-08-29 12:23 ` [PATCH 18/20] ath6kl: Fix default key installation in AP mode Jouni Malinen
2011-08-29 12:24 ` [PATCH 19/20] ath6kl: Do not clear CONNECT bit setting in AP mode for STA disconnect Jouni Malinen
2011-08-29 12:24 ` [PATCH 20/20] ath6kl: Include P2P IE(s) in GO Probe Response depending on request Jouni Malinen
2011-08-30  9:51 ` [PATCH 00/20] ath6kl: AP mode and P2P Kalle Valo
2011-08-30 15:54   ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5C797F.3090900@qca.qualcomm.com \
    --to=rmani@qca.qualcomm.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).