From: Felix Fietkau <nbd@openwrt.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
mcgrof@qca.qualcomm.com
Subject: Re: [PATCH 3.1] ath9k_hw: fix calibration on 5 ghz
Date: Tue, 30 Aug 2011 18:38:57 +0200 [thread overview]
Message-ID: <4E5D1221.7020705@openwrt.org> (raw)
In-Reply-To: <CAJ-Vmonvcrd49rQbgeyO3HCLxkTbww3mTypR87CuPBiu9uwhHA@mail.gmail.com>
Got confirmation that this is indeed the correct fix.
John, please merge this patch
On 2011-08-29 11:01 AM, Adrian Chadd wrote:
> Can we please hold off of this until we know if this is indeed the correct fix?
>
> Ie, I'm not sure yet whether 5ghz fast clock (which clocks the mac/bb
> like it was doing 2.4ghz) needs the dual ADCs enabled or not.
> It may be that something is being incorrectly disabled when the
> fastclock initvals are being written over the normal 5ghz values.
>
> Thanks,
>
>
> Adrian
>
> On 29 August 2011 16:06, Felix Fietkau<nbd@openwrt.org> wrote:
>> ADC calibrations cannot run on 5 GHz with fast clock enabled. They
>> need to be disabled, otherwise they'll hang and IQ mismatch calibration
>> will not be run either.
>>
>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
>> Reported-by: Adrian Chadd<adrian@freebsd.org>
>> Cc: stable@kernel.org
>> ---
>> drivers/net/wireless/ath/ath9k/ar9002_calib.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
>> index 2d4c091..2d394af 100644
>> --- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c
>> +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
>> @@ -41,7 +41,8 @@ static bool ar9002_hw_is_cal_supported(struct ath_hw *ah,
>> case ADC_DC_CAL:
>> /* Run ADC Gain Cal for non-CCK& non 2GHz-HT20 only */
>> if (!IS_CHAN_B(chan)&&
>> - !(IS_CHAN_2GHZ(chan)&& IS_CHAN_HT20(chan)))
>> + !((IS_CHAN_2GHZ(chan) || IS_CHAN_A_FAST_CLOCK(ah, chan))&&
>> + IS_CHAN_HT20(chan)))
>> supported = true;
>> break;
>> }
>> --
>> 1.7.3.2
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-08-30 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 8:06 [PATCH 3.1] ath9k_hw: fix calibration on 5 ghz Felix Fietkau
2011-08-29 9:01 ` Adrian Chadd
2011-08-29 10:14 ` Jorge Boncompte [DTI2]
2011-08-30 10:44 ` Rajkumar Manoharan
2011-08-30 10:47 ` Adrian Chadd
2011-08-30 11:27 ` Jorge Boncompte [DTI2]
2011-08-30 11:48 ` Rajkumar Manoharan
2011-08-30 16:38 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5D1221.7020705@openwrt.org \
--to=nbd@openwrt.org \
--cc=adrian@freebsd.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).