From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/4] ath6kl: Allow enabling of P2P support
Date: Tue, 6 Sep 2011 10:16:36 +0300 [thread overview]
Message-ID: <4E65C8D4.8030405@qca.qualcomm.com> (raw)
In-Reply-To: <4E65C49B.2000201@qca.qualcomm.com>
On 09/06/2011 09:58 AM, Kalle Valo wrote:
> On 09/05/2011 05:38 PM, Jouni Malinen wrote:
>> + if (ar->p2p) {
>> + ret = ath6kl_wmi_info_req_cmd(ar->wmi,
>> + P2P_FLAG_CAPABILITIES_REQ |
>> + P2P_FLAG_MACADDR_REQ |
>> + P2P_FLAG_HMODEL_REQ);
>> + if (ret) {
>> + ath6kl_dbg(ATH6KL_DBG_TRC, "failed to request P2P "
>> + "capabilities (%d) - assuming P2P not "
>> + "supported\n", ret);
>> + ar->p2p = 0;
>> + }
>> + }
>> +
>> + if (ar->p2p) {
>
> Can we combine this if block with the first one?
Forget this comment. I was blind and didn't see 'ar->p2p = 0'.
Kalle
next prev parent reply other threads:[~2011-09-06 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 14:38 [PATCH 0/4] ath6kl: Fix AP mode PS buffering and enable AP/P2P Jouni Malinen
2011-09-05 14:38 ` [PATCH 1/4] ath6kl: Fix WMI message structure for AP_SET_PVB Jouni Malinen
2011-09-05 14:38 ` [PATCH 2/4] ath6kl: Fix AP mode connect event parsing and TIM updates Jouni Malinen
2011-09-05 14:38 ` [PATCH 3/4] ath6kl: Allow AP mode to be configured Jouni Malinen
2011-09-05 14:38 ` [PATCH 4/4] ath6kl: Allow enabling of P2P support Jouni Malinen
2011-09-06 6:58 ` Kalle Valo
2011-09-06 7:16 ` Kalle Valo [this message]
2011-09-06 7:21 ` Jouni Malinen
2011-09-06 7:51 ` Kalle Valo
2011-09-06 9:35 ` Jouni Malinen
2011-09-07 7:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E65C8D4.8030405@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).