Re: [PATCH] rfkill: properly assign a boolean type

[mohammed <mohammed@qca.qualcomm.com>]

On Friday 16 September 2011 07:07 PM, Johannes Berg wrote:
> On Fri, 2011-09-16 at 19:03 +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>>   net/rfkill/core.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
>> index be90640..5be1957 100644
>> --- a/net/rfkill/core.c
>> +++ b/net/rfkill/core.c
>> @@ -235,7 +235,7 @@ static bool __rfkill_set_hw_state(struct rfkill *rfkill,
>>   	else
>>   		rfkill->state&= ~RFKILL_BLOCK_HW;
>>   	*change = prev != blocked;
>> -	any = rfkill->state&  RFKILL_BLOCK_ANY;
>> +	any = !!(rfkill->state&  RFKILL_BLOCK_ANY);
>
> I believe this is not necessary since "any" is a "bool" and as such
> should cast correctly to 0/1.

Hi johannes,

I agree the older one works perfectly fine. I stumbled upon this when i 
was trying to understand rfkill. but will not this change make it look 
better ? if it looks like a too trivial please drop it. Thanks!


>
> johannes
>