From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vivek Natarajan <nataraja@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: Indicate the roaming capability of the firmware
Date: Mon, 19 Sep 2011 09:52:56 +0300 [thread overview]
Message-ID: <4E76E6C8.3080003@qca.qualcomm.com> (raw)
In-Reply-To: <1316167723-2346-1-git-send-email-nataraja@qca.qualcomm.com>
On 09/16/2011 01:08 PM, Vivek Natarajan wrote:
> Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index b9b13a0..38d7e94 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
> if (!status)
> goto ath6kl_init_done;
>
> + ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
> +
> err_htc_stop:
> ath6kl_htc_stop(ar->htc_target);
> err_rxbuf_cleanup:
You have to document what this change means in practise and what issue
it is actually fixing. (firmware/wpas getting out of sync, wpas not
handling roaming after the flag is set etc.)
Also please address Sam's comment.
Kalle
prev parent reply other threads:[~2011-09-19 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 10:08 [PATCH] ath6kl: Indicate the roaming capability of the firmware Vivek Natarajan
2011-09-16 18:55 ` Sam Leffler
2011-09-19 6:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E76E6C8.3080003@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nataraja@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).