* [PATCH] ath6kl: Indicate the roaming capability of the firmware
@ 2011-09-16 10:08 Vivek Natarajan
2011-09-16 18:55 ` Sam Leffler
2011-09-19 6:52 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Vivek Natarajan @ 2011-09-16 10:08 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless
Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/init.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index b9b13a0..38d7e94 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
if (!status)
goto ath6kl_init_done;
+ ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
+
err_htc_stop:
ath6kl_htc_stop(ar->htc_target);
err_rxbuf_cleanup:
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath6kl: Indicate the roaming capability of the firmware
2011-09-16 10:08 [PATCH] ath6kl: Indicate the roaming capability of the firmware Vivek Natarajan
@ 2011-09-16 18:55 ` Sam Leffler
2011-09-19 6:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Sam Leffler @ 2011-09-16 18:55 UTC (permalink / raw)
To: Vivek Natarajan; +Cc: kvalo, linux-wireless
On Fri, Sep 16, 2011 at 3:08 AM, Vivek Natarajan
<nataraja@qca.qualcomm.com> wrote:
> Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index b9b13a0..38d7e94 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
> if (!status)
> goto ath6kl_init_done;
>
> + ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
> +
> err_htc_stop:
> ath6kl_htc_stop(ar->htc_target);
> err_rxbuf_cleanup:
> --
> 1.7.1
This is wrong. Here is the working version I pointed you at:
http://git.chromium.org/gitweb/?p=chromiumos/third_party/kernel.git;a=commit;h=b1785f108aee6d861d807701bcb6152c7145ded7
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath6kl: Indicate the roaming capability of the firmware
2011-09-16 10:08 [PATCH] ath6kl: Indicate the roaming capability of the firmware Vivek Natarajan
2011-09-16 18:55 ` Sam Leffler
@ 2011-09-19 6:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2011-09-19 6:52 UTC (permalink / raw)
To: Vivek Natarajan; +Cc: linux-wireless
On 09/16/2011 01:08 PM, Vivek Natarajan wrote:
> Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index b9b13a0..38d7e94 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1494,6 +1494,8 @@ static int ath6kl_init(struct net_device *dev)
> if (!status)
> goto ath6kl_init_done;
>
> + ar->wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_FW_ROAM;
> +
> err_htc_stop:
> ath6kl_htc_stop(ar->htc_target);
> err_rxbuf_cleanup:
You have to document what this change means in practise and what issue
it is actually fixing. (firmware/wpas getting out of sync, wpas not
handling roaming after the flag is set etc.)
Also please address Sam's comment.
Kalle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-19 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-16 10:08 [PATCH] ath6kl: Indicate the roaming capability of the firmware Vivek Natarajan
2011-09-16 18:55 ` Sam Leffler
2011-09-19 6:52 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).