From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rodrigue@qca.qualcomm.com
Subject: Re: [PATCH 12/12] ath9k: do not insert padding into tx buffers on AR9380+
Date: Mon, 19 Sep 2011 17:03:38 +0200 [thread overview]
Message-ID: <4E7759CA.4010100@openwrt.org> (raw)
In-Reply-To: <20110919144002.GA22040@vmraj-lnx.users.atheros.com>
On 2011-09-19 4:40 PM, Rajkumar Manoharan wrote:
> On Wed, Sep 14, 2011 at 09:24:27PM +0200, Felix Fietkau wrote:
>> With the new EDMA descriptor format, a single descriptor can contain up
>> to four buffer pointers. By splitting the buffer into two parts, we can
>> let the hardware add the padding internally instead of using memmove on
>> the skb data.
>>
>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 56 +++++++++++++++++++++-----------
>> 1 files changed, 37 insertions(+), 19 deletions(-)
>>
> Felix,
>
> This patch again introduced "ath: Failed to stop TX DMA!" for AR9380+ chips.
> After reverting this, the errors are completely gone away. Please look into this ASAP.
How frequent are these errors in your tests? I ran several tests on
embedded hardware with AR9380 and didn't notice any issues.
- Felix
next prev parent reply other threads:[~2011-09-19 15:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 19:24 [PATCH 01/12] ath9k: remove ATH_TX_XRETRY and BUF_XRETRY flags Felix Fietkau
2011-09-14 19:24 ` [PATCH 02/12] ath9k: reduce the number of functions that access the tx descriptor Felix Fietkau
2011-09-14 19:24 ` [PATCH 03/12] ath9k: move ath_buf_set_rate to remove a forward declaration Felix Fietkau
2011-09-14 19:24 ` [PATCH 04/12] ath9k: call ath9k_hw_set_desc_link for beacon descriptors Felix Fietkau
2011-09-14 19:24 ` [PATCH 05/12] ath9k_hw: do not recalculate the descriptor checksum in ar9003_hw_fill_txdesc Felix Fietkau
2011-09-14 19:24 ` [PATCH 06/12] ath9k_hw: add a new API for setting tx descriptors Felix Fietkau
2011-09-14 19:24 ` [PATCH 07/12] ath9k: use the " Felix Fietkau
2011-09-14 19:24 ` [PATCH 08/12] ath9k_hw: remove the old tx descriptor API Felix Fietkau
2011-09-14 19:24 ` [PATCH 09/12] ath9k: optimize ath9k_ps_restore Felix Fietkau
2011-09-14 19:24 ` [PATCH 10/12] ath9k: remove a redundant check in ath_tx_form_aggr Felix Fietkau
2011-09-14 19:24 ` [PATCH 11/12] ath9k: optimize ath_tx_rc_status usage Felix Fietkau
2011-09-14 19:24 ` [PATCH 12/12] ath9k: do not insert padding into tx buffers on AR9380+ Felix Fietkau
2011-09-19 14:40 ` Rajkumar Manoharan
2011-09-19 15:03 ` Felix Fietkau [this message]
2011-09-19 16:47 ` Rajkumar Manoharan
2011-09-19 17:39 ` Felix Fietkau
2011-09-22 5:49 ` [PATCH 09/12] ath9k: optimize ath9k_ps_restore Vivek Natarajan
2011-09-22 13:54 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7759CA.4010100@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).