From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/9] ath6kl: Use cfg80211 BSS table without local node table
Date: Thu, 22 Sep 2011 10:24:32 +0300 [thread overview]
Message-ID: <4E7AE2B0.3060905@qca.qualcomm.com> (raw)
In-Reply-To: <1316448907-10166-1-git-send-email-jouni@qca.qualcomm.com>
On 09/19/2011 07:14 PM, Jouni Malinen wrote:
> This patch set fixes number of issues in how scan results were being
> reported to cfg80211 by properly using the cfg80211 BSS inform
> mechanism. There is no point in maintaining the internal node table in
> ath6kl since it is not really used for anything and the duplicated table
> implementation was just trying to handle functionality that is already
> present in cfg80211. In addition to fixing various roaming cases that
> resulted in errors due to incorrect information in the cfg80211 BSS
> table, this series removes the internal node table implementation that
> had its own issues that apparently could cause crashes in some cases.
This is really cool. I hated the node table right from the beginning.
I noticed that there were two magic constants used few times, 8 + 2 + 2
for the IE length and 95 for RSSI conversion. I would prefer to use a
define for those, but that can be changed later.
I have applied all nine patches. Thank you!
Kalle
prev parent reply other threads:[~2011-09-22 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 16:14 [PATCH 0/9] ath6kl: Use cfg80211 BSS table without local node table Jouni Malinen
2011-09-19 16:14 ` [PATCH 1/9] ath6kl: Fix BSS update on roaming Jouni Malinen
2011-09-19 16:15 ` [PATCH 2/9] ath6kl: Remove deprecated WMI_OPT_RX_FRAME_EVENTID processing Jouni Malinen
2011-09-19 16:15 ` [PATCH 3/9] ath6kl: Remove RSSI update for internal node table Jouni Malinen
2011-09-19 16:15 ` [PATCH 4/9] ath6kl: Remove unnecessary node table update on disconnect event Jouni Malinen
2011-09-19 16:15 ` [PATCH 5/9] ath6kl: Replace internal node table with cfg80211 BSS table Jouni Malinen
2011-09-19 16:15 ` [PATCH 6/9] ath6kl: Remove the unused node table implementation Jouni Malinen
2011-09-19 16:15 ` [PATCH 7/9] ath6kl: Remove unnecessary bssinfo event header conversion Jouni Malinen
2011-09-19 16:15 ` [PATCH 8/9] ath6kl: Update BSS information after connection Jouni Malinen
2011-09-19 16:15 ` [PATCH 9/9] ath6kl: Export beacon interval and DTIM period through STA info Jouni Malinen
2011-09-22 7:24 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7AE2B0.3060905@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).