From: "Roland Vossen" <rvossen@broadcom.com>
To: "johannes Berg" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Questions on ieee80211_frame_duration()
Date: Tue, 27 Sep 2011 12:08:24 +0200 [thread overview]
Message-ID: <4E81A098.9040708@broadcom.com> (raw)
Hello Johannes,
in response to one of your brcm80211 review comments, I am trying to
replace functions that calculate frame duration with Mac80211 counterparts.
As such, I have a hard time grasping this function:
http://lxr.free-electrons.com/source/net/mac80211/util.c#L108
A couple of questions:
a. The comment in the 'else' branch does not mention 802.11n, but I
think it should. Agree ?
b. The long/short preamble choice applies to CCK rates only. But this
function does not take that into account. Is that on purpose ?
c. In 802.11n there are 4 preamble types possible:
- long (CCK rates)
- short (CCK rates)
- green field
- mixed mode
The function does not seem to take the last two types into account.
Should it ?
Bye, Roland.
next reply other threads:[~2011-09-27 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 10:08 Roland Vossen [this message]
2011-09-27 11:10 ` Questions on ieee80211_frame_duration() Johannes Berg
2011-09-28 7:19 ` Roland Vossen
2011-09-28 7:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81A098.9040708@broadcom.com \
--to=rvossen@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox