linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ath6kl: Enable force foreground scan in connected state
@ 2011-10-01  9:25 Vasanthakumar Thiagarajan
  2011-10-01  9:26 ` Kalle Valo
  0 siblings, 1 reply; 5+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-10-01  9:25 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless

This was disabled beacause there was a network stall
issue when scan is issued. This issue does not happen
with the new firmware, enable it back.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 8d9fbd4..c50697d 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -639,6 +639,7 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy, struct net_device *ndev,
 	s8 n_channels = 0;
 	u16 *channels = NULL;
 	int ret = 0;
+	u32 force_fg_scan = 0;
 
 	if (!ath6kl_cfg80211_ready(ar))
 		return -EIO;
@@ -700,7 +701,10 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy, struct net_device *ndev,
 			channels[i] = request->channels[i]->center_freq;
 	}
 
-	ret = ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, 0,
+	if (test_bit(CONNECTED, &ar->flag))
+		force_fg_scan = 1;
+
+	ret = ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, force_fg_scan,
 				       false, 0, 0, n_channels, channels);
 	if (ret)
 		ath6kl_err("wmi_startscan_cmd failed\n");
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ath6kl: Enable force foreground scan in connected state
  2011-10-01  9:25 [PATCH] ath6kl: Enable force foreground scan in connected state Vasanthakumar Thiagarajan
@ 2011-10-01  9:26 ` Kalle Valo
  2011-10-01  9:50   ` Kalle Valo
  0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2011-10-01  9:26 UTC (permalink / raw)
  To: Vasanthakumar Thiagarajan; +Cc: linux-wireless

On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> This was disabled beacause there was a network stall
> issue when scan is issued. This issue does not happen
> with the new firmware, enable it back.

Please mention the firmware version which has the fix in the commit log.

Kalle

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ath6kl: Enable force foreground scan in connected state
  2011-10-01  9:26 ` Kalle Valo
@ 2011-10-01  9:50   ` Kalle Valo
  2011-10-01 10:42     ` Vasanthakumar Thiagarajan
  0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2011-10-01  9:50 UTC (permalink / raw)
  To: Vasanthakumar Thiagarajan; +Cc: linux-wireless

On 10/01/2011 12:26 PM, Kalle Valo wrote:
> On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
>> This was disabled beacause there was a network stall
>> issue when scan is issued. This issue does not happen
>> with the new firmware, enable it back.
> 
> Please mention the firmware version which has the fix in the commit log.

And I can't apply this before the new firmware available, preferably
even commited to linux-firmware repo.

Kalle

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ath6kl: Enable force foreground scan in connected state
  2011-10-01  9:50   ` Kalle Valo
@ 2011-10-01 10:42     ` Vasanthakumar Thiagarajan
  2011-10-01 10:48       ` Vasanthakumar Thiagarajan
  0 siblings, 1 reply; 5+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-10-01 10:42 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless

On Sat, Oct 01, 2011 at 12:50:11PM +0300, Kalle Valo wrote:
> On 10/01/2011 12:26 PM, Kalle Valo wrote:
> > On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> >> This was disabled beacause there was a network stall
> >> issue when scan is issued. This issue does not happen
> >> with the new firmware, enable it back.
> > 
> > Please mention the firmware version which has the fix in the commit log.
> 
> And I can't apply this before the new firmware available, preferably
> even commited to linux-firmware repo.

Sure, i'm fine with that.

Vasanth

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ath6kl: Enable force foreground scan in connected state
  2011-10-01 10:42     ` Vasanthakumar Thiagarajan
@ 2011-10-01 10:48       ` Vasanthakumar Thiagarajan
  0 siblings, 0 replies; 5+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-10-01 10:48 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless

On Sat, Oct 01, 2011 at 04:12:19PM +0530, Vasanthakumar Thiagarajan wrote:
> On Sat, Oct 01, 2011 at 12:50:11PM +0300, Kalle Valo wrote:
> > On 10/01/2011 12:26 PM, Kalle Valo wrote:
> > > On 10/01/2011 12:25 PM, Vasanthakumar Thiagarajan wrote:
> > >> This was disabled beacause there was a network stall
> > >> issue when scan is issued. This issue does not happen
> > >> with the new firmware, enable it back.
> > > 
> > > Please mention the firmware version which has the fix in the commit log.
> > 
> > And I can't apply this before the new firmware available, preferably
> > even commited to linux-firmware repo.
> 
> Sure, i'm fine with that.

Actually, the new firmware is sent upstream and merged into
linux-firmware repo just now.

Vasanth

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-10-01 10:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-01  9:25 [PATCH] ath6kl: Enable force foreground scan in connected state Vasanthakumar Thiagarajan
2011-10-01  9:26 ` Kalle Valo
2011-10-01  9:50   ` Kalle Valo
2011-10-01 10:42     ` Vasanthakumar Thiagarajan
2011-10-01 10:48       ` Vasanthakumar Thiagarajan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).