linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jeffray <ian@emobix.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: r8712u driver - on ARM
Date: Sat, 01 Oct 2011 18:00:53 +0100	[thread overview]
Message-ID: <4E874745.1010908@emobix.co.uk> (raw)
In-Reply-To: <4E873944.70104@lwfinger.net>

On 01/10/2011 17:01, Larry Finger wrote:
> Ian,
>
> Most of the skb assignments in r8712u are aligned OK and most aligned on
> 512-byte boundaries, but there was one that had the minimal offset of 14
> bytes. The attached patch should fix it. Does it help?

Hi Larry,

Very many thanks for looking at this - I tried to look in to it
myself but realised I don't have a good understanding about what's
going on.

I won't have access to my problematic ARM system until Monday, but
I've tried this on Blackfin with musb and there's no change in
operation unfortunately.

But - I added some printk() debug in this area of the code and it
seem amsdu_to_msdu() is never called, on Blackfin or on x86 - even
when the driver is fully active and transferring data on an x86 PC.

Ian

-- 
Ian Jeffray    ian@emobix.co.uk    Tel: +44 (0) 141 221 8449
emobix Limited, Suite 5/5, 29 St Vincent Place, Glasgow, G1 2DT
Registered in Scotland; Company No. 371276 - VAT No. 983 4833 78

      parent reply	other threads:[~2011-10-01 17:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 15:36 r8712u driver - on ARM Ian Jeffray
2011-09-27 16:24 ` Larry Finger
2011-09-30 18:39   ` Ian Jeffray
2011-09-30 19:06     ` Christian Lamparter
2011-10-01  0:51       ` Larry Finger
2011-10-01 16:01       ` Larry Finger
2011-10-01 16:22         ` Christian Lamparter
2011-10-01 17:52           ` Larry Finger
2011-10-01 18:01             ` Christian Lamparter
2011-10-01 18:10               ` Ian Jeffray
2011-10-01 18:49                 ` Larry Finger
2011-10-01 18:54                   ` Christian Lamparter
2011-10-01 19:24                     ` Larry Finger
2011-10-01 23:24                       ` Ian Jeffray
2011-10-12 15:30                         ` Ian Jeffray
2011-10-12 17:28                           ` Larry Finger
2011-10-01 17:00         ` Ian Jeffray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E874745.1010908@emobix.co.uk \
    --to=ian@emobix.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).