From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Thiagarajan, Vasanthakumar" <vthiagar@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/5] ath6kl: Fix possible race in accessing bounce buffer
Date: Tue, 4 Oct 2011 11:08:50 +0300 [thread overview]
Message-ID: <4E8ABF12.9080607@qca.qualcomm.com> (raw)
In-Reply-To: <EDA962D9696870498097087E0373E7710B5AA5@nasanexd01e.na.qualcomm.com>
On 10/03/2011 06:52 PM, Thiagarajan, Vasanthakumar wrote:
>
> ________________________________________
> From: Thiagarajan, Vasanthakumar
> Sent: Friday, September 30, 2011 7:18 PM
> To: Valo, Kalle
> Cc: linux-wireless@vger.kernel.org
> Subject: [PATCH 4/5] ath6kl: Fix possible race in accessing bounce buffer
>
> There is only one bounce buffer (ar_sdio->dma_buffer) which is used
> for both read and write without any protection. Fix this race by
> allocating bounce buffer every time when it is needed.
>
> As I have never seen any race in bounce buffer practically during my testing,
> this patch can be dropped instead of making the code complex for no reason.
Heh, we got lucky again. I had applied the patches but forgot to push
them to github. So I was able to drop patches 4 and 5.
Kalle
next prev parent reply other threads:[~2011-10-04 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:48 [PATCH 1/5] ath6kl: Fix sparse warning "symbol 'conn' shadows an earlier one" Vasanthakumar Thiagarajan
2011-09-30 13:48 ` [PATCH 2/5] ath6kl: Replace spin_lock_irqsave with spin_lock_bh Vasanthakumar Thiagarajan
2011-09-30 13:48 ` [PATCH 3/5] ath6kl: Claim sdio function only at appropriate places Vasanthakumar Thiagarajan
2011-09-30 13:48 ` [PATCH 4/5] ath6kl: Fix possible race in accessing bounce buffer Vasanthakumar Thiagarajan
2011-10-03 15:52 ` Thiagarajan, Vasanthakumar
2011-10-04 8:08 ` Kalle Valo [this message]
2011-10-10 4:52 ` Vasanthakumar Thiagarajan
2011-09-30 13:48 ` [PATCH 5/5] ath6kl: Remove unused ar_sdio->dma_buffer Vasanthakumar Thiagarajan
2011-10-03 11:08 ` [PATCH 1/5] ath6kl: Fix sparse warning "symbol 'conn' shadows an earlier one" Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8ABF12.9080607@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).