From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>
Cc: John W Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Convert to use crc8 code in kernel library
Date: Sat, 08 Oct 2011 18:00:07 -0500 [thread overview]
Message-ID: <4E90D5F7.6020005@lwfinger.net> (raw)
In-Reply-To: <1318113514.1844.34.camel@Joe-Laptop>
On 10/08/2011 05:38 PM, Joe Perches wrote:
> On Sat, 2011-10-08 at 17:28 -0500, Larry Finger wrote:
>> The kernel now contains library routines to establish crc8 tables and
>> to calculate the appropriate sums. Use them for ssb.
> []
>> --- wireless-testing-new.orig/drivers/ssb/pci.c
> []
>> +static inline void ltoh16_buf(u16 *buf, unsigned int size)
>
> Perhaps a rename and use le16_to_cpup?
>
>> +static inline void htol16_buf(u16 *buf, unsigned int size)
>
> and cpu_to_le16p?
I'm sorry, but I don't see any advantage to using a pointer version here. Please
enlighten me.
Thanks,
Larry
next prev parent reply other threads:[~2011-10-08 23:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 22:28 [PATCH] ssb: Convert to use crc8 code in kernel library Larry Finger
2011-10-08 22:38 ` Joe Perches
2011-10-08 23:00 ` Larry Finger [this message]
2011-10-08 23:11 ` Joe Perches
2011-10-08 22:51 ` Michael Büsch
2011-10-09 8:48 ` Rafał Miłecki
2011-10-09 10:33 ` Arend van Spriel
2011-10-09 14:35 ` Larry Finger
2011-10-09 9:50 ` Arend van Spriel
2011-10-14 15:11 ` Pavel Roskin
2011-10-14 15:30 ` Arend van Spriel
2011-10-14 16:30 ` Larry Finger
2011-10-14 16:47 ` Michael Büsch
2011-10-15 8:27 ` Arend van Spriel
2011-10-15 13:29 ` Larry Finger
2011-10-15 13:53 ` Michael Büsch
2011-10-15 14:18 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E90D5F7.6020005@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).