From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/5] ath6kl: Add debugfs control for keepalive and disconnection timeout
Date: Tue, 11 Oct 2011 14:55:40 +0300 [thread overview]
Message-ID: <4E942EBC.9030702@qca.qualcomm.com> (raw)
In-Reply-To: <1318243411-16110-5-git-send-email-jouni@qca.qualcomm.com>
On 10/10/2011 01:43 PM, Jouni Malinen wrote:
> The new debugfs files keepalive and disconnect_timeout can be used to
> fetch the current values and to change the values for keepalive and
> disconnect event timeout (both in seconds).
[...]
> --- a/drivers/net/wireless/ath/ath6kl/wmi.c
> +++ b/drivers/net/wireless/ath/ath6kl/wmi.c
> @@ -1940,6 +1940,10 @@ int ath6kl_wmi_disctimeout_cmd(struct wmi *wmi, u8 timeout)
>
> ret = ath6kl_wmi_cmd_send(wmi, skb, WMI_SET_DISC_TIMEOUT_CMDID,
> NO_SYNC_WMIFLAG);
> +#ifdef CONFIG_ATH6KL_DEBUG
> + if (ret == 0)
> + wmi->parent_dev->debug.disc_timeout = timeout;
> +#endif /* CONFIG_ATH6KL_DEBUG */
> return ret;
> }
>
> @@ -2524,6 +2528,10 @@ int ath6kl_wmi_set_keepalive_cmd(struct wmi *wmi, u8 keep_alive_intvl)
>
> ret = ath6kl_wmi_cmd_send(wmi, skb, WMI_SET_KEEPALIVE_CMDID,
> NO_SYNC_WMIFLAG);
> +#ifdef CONFIG_ATH6KL_DEBUG
> + if (ret == 0)
> + wmi->parent_dev->debug.keepalive = keep_alive_intvl;
> +#endif /* CONFIG_ATH6KL_DEBUG */
Similar comment for these two as well. It would better to have the code
in debug.c (or .h) and add functions for providing this information.
Kalle
next prev parent reply other threads:[~2011-10-11 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 10:43 [PATCH 0/5] ath6kl: Debugging and roaming Jouni Malinen
2011-10-10 10:43 ` [PATCH 1/5] ath6kl: Add endpoint_stats debugfs file Jouni Malinen
2011-10-10 10:43 ` [PATCH 2/5] ath6kl: Add debugfs file for target roam table Jouni Malinen
2011-10-11 11:39 ` Kalle Valo
2011-10-10 10:43 ` [PATCH 3/5] ath6kl: Add debugfs files for roaming control Jouni Malinen
2011-10-10 10:43 ` [PATCH 4/5] ath6kl: Add debugfs control for keepalive and disconnection timeout Jouni Malinen
2011-10-11 11:55 ` Kalle Valo [this message]
2011-10-10 10:43 ` [PATCH 5/5] ath6kl: Allow CCKM AKM and KRK to be configured Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E942EBC.9030702@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).