linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mark Einon <mark.einon@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/5 V2] rtlwifi: Change PCI drivers to use the new PM framework
Date: Wed, 12 Oct 2011 10:20:33 -0500	[thread overview]
Message-ID: <4E95B041.3000209@lwfinger.net> (raw)
In-Reply-To: <CANK3SE1zJDKry-r-M384jqo7rQezgj2FzbXBLS6SCMiaL934kw@mail.gmail.com>

On 10/12/2011 09:02 AM, Mark Einon wrote:
> On 12 October 2011 03:28, Larry Finger<Larry.Finger@lwfinger.net>  wrote:
>
>>
>> +static const struct dev_pm_ops rtlwifi_pm_ops = {
>> +       .suspend = rtl_pci_suspend,
>> +       .resume = rtl_pci_resume,
>> +       .freeze = rtl_pci_suspend,
>> +       .thaw = rtl_pci_resume,
>> +       .poweroff = rtl_pci_suspend,
>> +       .restore = rtl_pci_resume,
>> +};
>> +
>
> Hi Larry,
>
> You can save a few lines of code here, and in the other files where it
> is done - there is a convenience macro for simplifying creating a
> pm_ops struct like this, see SIMPLE_DEV_PM_OPS() in pm.h.

Mark,

Thanks for the tip.

Larry


  reply	other threads:[~2011-10-12 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  2:28 [PATCH 0/5 V2] Updates to match latest Realtek version and new PM framework Larry Finger
2011-10-12  2:28 ` [PATCH 1/5 V2] rtlwifi: Change PCI drivers to use the " Larry Finger
2011-10-12 14:02   ` Mark Einon
2011-10-12 15:20     ` Larry Finger [this message]
2011-10-12  2:28 ` [PATCH 2/5 V2] rtlwifi: Update to new Realtek version - Part I Larry Finger
2011-10-12  2:28 ` [PATCH 3/5 V2] rtlwifi: rtl8192ce: Add new chip revisions Larry Finger
2011-10-12  2:28 ` [PATCH 4/5 V2] rtlwifi: rtl8192se: Updates from latest Realtek driver version - Part II Larry Finger
2011-10-12 18:32   ` John W. Linville
2011-10-12  2:28 ` [PATCH 5/5 V2] rtlwifi: rtl8192de: Updates from latest Reaktek driver - Part III Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E95B041.3000209@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mark.einon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).