From: Loiseau Lucien <loiseau.lucien@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] patch on comment
Date: Fri, 14 Oct 2011 17:30:01 +0200 [thread overview]
Message-ID: <4E985579.9010401@gmail.com> (raw)
In-Reply-To: <1318433496.3933.44.camel@jlt3.sipsolutions.net>
Digging into the source code, i noticed that the documentation tells
that the tx function from ieee80211_ops should return NETDEV_TX_OK while
the tx function is now a void function. Here is a very little patch to
remove this information from the comment :
--- mac80211.h
+++ mac80211.h
@@ -1744,8 +1744,6 @@
* configuration in the TX control data. This handler should,
* preferably, never fail and stop queues appropriately, more
* importantly, however, it must never fail for A-MPDU-queues.
- * This function should return NETDEV_TX_OK except in very
- * limited cases.
* Must be implemented and atomic.
*
* @start: Called before the first netdevice attached to the hardware
Best Regards,
Lucien Loiseau.
next prev parent reply other threads:[~2011-10-14 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 8:15 [PATCH v2] mac80211: pass vif param to conf_tx() callback Eliad Peller
2011-10-12 15:31 ` Johannes Berg
2011-10-14 9:54 ` Eliad Peller
2011-10-14 15:30 ` Loiseau Lucien [this message]
2011-10-14 17:19 ` [PATCH] patch on comment Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E985579.9010401@gmail.com \
--to=loiseau.lucien@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).