From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>,
reinette chatre <reinette.chatre@intel.com>
Subject: Re: [RFC] mac80211: properly go back to operational channel?
Date: Tue, 18 Oct 2011 09:03:10 -0700 [thread overview]
Message-ID: <4E9DA33E.2000603@candelatech.com> (raw)
In-Reply-To: <4E9D9306.1060005@openwrt.org>
On 10/18/2011 07:53 AM, Felix Fietkau wrote:
> On 2011-10-18 4:30 PM, Johannes Berg wrote:
>> On Tue, 2011-10-18 at 16:19 +0200, Stanislaw Gruszka wrote:
>>> For local->tmp_channel == NULL and local->scan_channel == NULL
>>> ieee80211_cfg_on_oper_channel() will return false if
>>> local->oper_channel != local->hw.conf.channel,
>>> hece we do not properly go back to oper_channel from tmp_channel.
>>
>> Huh, good catch.
>>
>>> Does patch have sense?
>>
>> Let's see what Ben says. It seems a bit like the
>> ieee80211_cfg_on_oper_channel() test there should be inverted instead of
>> removed?
>>
>>> Could it fixes problems we are talking
>>> in this thread?
>>
>> Yes, could be related, also some issue Jouni and Reinette have been
>> seeing with P2P might be related as well.
> Just remembered this old patch, also related to this part:
> http://news.gmane.org/find-root.php?message_id=%3c1311607763%2d12603%2d3%2dgit%2dsend%2demail%2deliad%40wizery.com%3e
I thought that patch was going into the kernel.
I'm busy this morning, but I'm hacking on wifi later today if
all goes well, so I can test out this patch.
Thanks,
Ben
>
> - Felix
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-10-18 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 11:12 [RFC] mac80211: remove per band sta supported rates Stanislaw Gruszka
2011-09-27 11:34 ` Johannes Berg
2011-09-29 15:00 ` Stanislaw Gruszka
2011-10-04 15:07 ` Johannes Berg
2011-10-05 11:15 ` Stanislaw Gruszka
2011-10-05 11:22 ` Johannes Berg
2011-10-18 14:19 ` [RFC] mac80211: properly go back to operational channel? Stanislaw Gruszka
2011-10-18 14:30 ` Johannes Berg
2011-10-18 14:53 ` Felix Fietkau
2011-10-18 16:03 ` Ben Greear [this message]
2011-10-19 18:48 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9DA33E.2000603@candelatech.com \
--to=greearb@candelatech.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).