linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Nico Schottelius" <nico-linux-20111017@schottelius.org>,
	"Eric Dumazet" <eric.dumazet@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: BUG: All network processes hang (brcmsmac/wpa_supplicant)
Date: Wed, 19 Oct 2011 18:48:17 +0200	[thread overview]
Message-ID: <4E9EFF51.6000104@broadcom.com> (raw)
In-Reply-To: <20111019145501.GB1414@schottelius.org>


[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]

On 10/19/2011 04:55 PM, Nico Schottelius wrote:
> Hey Arend,
> 
> 
> Arend van Spriel [Wed, Oct 19, 2011 at 04:43:27PM +0200]:
>> I actually don't see the rtnl_lock or mutex_lock that was listed in your
>> original dmesg. There are a lot of warning traces from mac80211.c.

The warnings are probably a diversion. This is the warning in
ieee80211_rx():

			if (WARN_ON(status->rate_idx < 0 ||
				    status->rate_idx >= sband->n_bitrates))
				goto drop;
			rate = &sband->bitrates[status->rate_idx];

This means that the driver (brcmsmac) provides a data packet with an
out-of-range rate index. This reminded me of a fix I made about a month
ago. Could you apply the attached patch file. It is based on:

commit bee709ab1d390afe69e4407bc86bb706c6fb2965
Merge: ad1c761 1f2c7e9
Author: Nico Schottelius <nico@kr.ethz.ch>
Date:   Tue Oct 18 00:04:05 2011 +0200

    Merge branch 'fix-edp-vdd-power' of ../keithp/linux

As it drops receive packets it may be your problem. Is your AP on 5GHz?

Gr. AvS

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-staging-brcm80211-fix-for-rate-index-in-receive-stat.patch --]
[-- Type: text/x-patch; name="0001-staging-brcm80211-fix-for-rate-index-in-receive-stat.patch", Size: 1096 bytes --]

From 7d14bd6cbfbf26369c5958e56a468fd8429841d7 Mon Sep 17 00:00:00 2001
From: Arend van Spriel <arend@broadcom.com>
Date: Wed, 19 Oct 2011 18:42:45 +0200
Subject: [PATCH] staging: brcm80211: fix for rate index in receive status

Made a patch for Nico to try whether this resolves his issue.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
 drivers/staging/brcm80211/brcmsmac/main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmsmac/main.c b/drivers/staging/brcm80211/brcmsmac/main.c
index 1763c45..49c8eb9 100644
--- a/drivers/staging/brcm80211/brcmsmac/main.c
+++ b/drivers/staging/brcm80211/brcmsmac/main.c
@@ -4608,6 +4608,10 @@ prep_mac80211_status(struct brcms_c_info *wlc, struct d11rxhdr *rxh,
 			wiphy_err(wlc->wiphy, "%s: Unknown rate\n", __func__);
 		}
 
+		/* DEBUG: fix rate index in receive status */
+		if (rx_status->band == IEEE80211_BAND_5GHZ)
+			rx_status->rate_idx -= 4;
+
 		/* Determine short preamble and rate_idx */
 		preamble = 0;
 		if (IS_CCK(rspec)) {
-- 
1.7.4.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

  reply	other threads:[~2011-10-19 16:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111018111422.GA1979@schottelius.org>
2011-10-18 13:14 ` BUG: All network processes hang (brcmsmac/wpa_supplicant) Arend van Spriel
2011-10-18 13:34   ` Nico Schottelius
     [not found]   ` <1318940665.2657.60.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
2011-10-19 12:36     ` Nico Schottelius
2011-10-19 12:49       ` Eric Dumazet
2011-10-19 12:58         ` Arend van Spriel
2011-10-19 13:05           ` Eric Dumazet
2011-10-19 13:09             ` Nico Schottelius
2011-10-19 13:07         ` Nico Schottelius
2011-10-19 14:28           ` Nico Schottelius
2011-10-19 14:43             ` Arend van Spriel
2011-10-19 14:55               ` Nico Schottelius
2011-10-19 16:48                 ` Arend van Spriel [this message]
2011-10-19 21:42                   ` Nico Schottelius
2011-10-20  6:28                     ` Arend van Spriel
2011-10-22  1:59                       ` Nico Schottelius
2011-10-22  8:13                         ` Arend Van Spriel
2011-10-22  8:30                           ` Greg KH
2011-10-22  8:44                             ` Arend van Spriel
2011-10-23 10:04                         ` Arend van Spriel
2011-10-23 10:53                           ` Nico Schottelius
2011-10-23 19:48                             ` Nico Schottelius
2011-10-24 12:50                               ` Arend van Spriel
2011-10-25  6:41                                 ` Nico Schottelius
2011-10-19 14:46             ` Eric Dumazet
2011-10-19 14:58               ` Nico Schottelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9EFF51.6000104@broadcom.com \
    --to=arend@broadcom.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico-linux-20111017@schottelius.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).