Re: [RFC] mac80211: properly go back to operational channel?

[Ben Greear <greearb@candelatech.com>]

On 10/18/2011 07:30 AM, Johannes Berg wrote:
> On Tue, 2011-10-18 at 16:19 +0200, Stanislaw Gruszka wrote:
>> For local->tmp_channel == NULL and local->scan_channel == NULL
>> ieee80211_cfg_on_oper_channel() will return false if
>> local->oper_channel != local->hw.conf.channel,
>> hece we do not properly go back to oper_channel from tmp_channel.
>
> Huh, good catch.
>
>> Does patch have sense?
>
> Let's see what Ben says. It seems a bit like the
> ieee80211_cfg_on_oper_channel() test there should be inverted instead of
> removed?
>
>> Could it fixes problems we are talking
>> in this thread?
>
> Yes, could be related, also some issue Jouni and Reinette have been
> seeing with P2P might be related as well.

Please see the patch I just posted.  I think it fixes the
issue (which was originally reported by
Eliad Peller <eliad@wizery.com>, who also posted a patch).
I re-worked his suggested patch to what I believe is a more
proper patch.

Also, Eliad had posted another patch that seems to be good
as is (which I also just re-posted).

Obviously, my tests cases are not catching all of these issues,
so please review the patches and/or test them out to see if
they fix the problem.

Thanks,
Ben

>
> johannes
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com