From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sangwook Lee <sangwook.lee@linaro.org>
Cc: <linux-wireless@vger.kernel.org>, <patches@linaro.org>
Subject: Re: [PATCH] ath6kl: Fix compile error for ARM
Date: Thu, 27 Oct 2011 11:33:03 +0300 [thread overview]
Message-ID: <4EA9173F.3050001@qca.qualcomm.com> (raw)
In-Reply-To: <1319642918-27076-1-git-send-email-sangwook.lee@linaro.org>
On 10/26/2011 06:28 PM, Sangwook Lee wrote:
> Fix the compile error for ARM Platform.
>
> Signed-off-by: Sangwook Lee <sangwook.lee@linaro.org>
> ---
>
> Compile errors come from ARM plaform:
> In file included from drivers/net/wireless/ath/ath6kl/init.c:19:0:
> include/linux/of.h: In function ‘of_property_read_u32_array’:
> include/linux/of.h:249:10: error: ‘ENOSYS’ undeclared
In my opinion this is a bug in of.h and I sent a patch few weeks ago:
https://lkml.org/lkml/2011/10/6/133
But it seems that openfirmware maintainers don't care as I haven't
received any reply to the patch. So let's just workaround this in ath6kl.
Patch applied, but I changed the commit log a bit. Thank you again.
commit e0627e2c7e0647d174d9fcac06fa194d38740f7d
Author: Sangwook Lee <sangwook.lee@linaro.org>
Date: Wed Oct 26 16:28:38 2011 +0100
ath6kl: Fix compilation error from of.h
When compiling ath6kl for ARM with device tree tree compilation fails
with errors like:
include/linux/of.h: In function 'of_property_read_u32_array':
include/linux/of.h:249:10: error: 'ENOSYS' undeclared
Workaround this by including errno.h from init.c.
kvalo: improved commit log
Signed-off-by: Sangwook Lee <sangwook.lee@linaro.org>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Kalle
prev parent reply other threads:[~2011-10-27 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 15:28 [PATCH] ath6kl: Fix compile error for ARM Sangwook Lee
2011-10-27 8:33 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA9173F.3050001@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sangwook.lee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).