From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/7] ath6kl: Add new functions to handle wow suspend/resume operations
Date: Fri, 28 Oct 2011 15:31:11 +0300 [thread overview]
Message-ID: <4EAAA08F.5070905@qca.qualcomm.com> (raw)
In-Reply-To: <1319539047-8756-5-git-send-email-rmani@qca.qualcomm.com>
On 10/25/2011 01:37 PM, rmani@qca.qualcomm.com wrote:
> From: Raja Mani <rmani@qca.qualcomm.com>
>
> Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
Empty commit log.
> +int ath6kl_pm_wow_suspend(struct ath6kl *ar, struct cfg80211_wowlan *wow)
> +{
> + struct wmi_set_wow_mode_cmd wakeup_filter_cmd;
> + struct wmi_add_wow_pattern_cmd add_pattern_cmd;
> + struct wmi_del_wow_pattern_cmd del_pattern_cmd;
> + struct wmi_set_host_sleep_mode_cmd hsleep_cmd;
> + int i, ret, pos, left;
> + u8 mask[WOW_PATTERN_SIZE];
> +
> + if (WARN_ON(!wow))
> + return -EINVAL;
Unnecessary null check, wow is non-zero here.
> + for (pos = 0; pos < wow->patterns[i].pattern_len;
> + pos++) {
> + if (wow->patterns[i].mask[pos / 8] & (0x1 << (pos % 8)))
> + mask[pos] = 0xFF;
This loop needs a comment.
> + if (ar->tx_pending[ar->ctrl_ep]) {
> + left = wait_event_interruptible_timeout(ar->event_wq,
> + ar->tx_pending[ar->ctrl_ep] == 0, WMI_TIMEOUT);
> + if (left == 0) {
> + ret = -ETIMEDOUT;
> + goto wow_setup_failed;
> + } else if (left < 0) {
> + ret = left;
> + goto wow_setup_failed;
A warning message for both of these error case would be nice.
> +#define WOW_HOST_REQ_DELAY 500 /* 500 ms */
No point of duplicating the value, "/* ms */" is enough.
Kalle
next prev parent reply other threads:[~2011-10-28 12:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 10:37 [PATCH 0/7] ath6kl: Add WOW support rmani
2011-10-25 10:37 ` [PATCH 1/7] ath6kl: Add wmi functions to add/delete wow patterns rmani
2011-10-28 12:11 ` Kalle Valo
2011-10-31 9:52 ` Raja Mani
2011-10-25 10:37 ` [PATCH 2/7] ath6kl: Add wmi functions to configure wow mode and host sleep mode rmani
2011-10-28 12:19 ` Kalle Valo
2011-10-31 9:53 ` Raja Mani
2011-10-31 13:10 ` Kalle Valo
2011-10-25 10:37 ` [PATCH 3/7] ath6kl: Introduce new variable to track wow state machine rmani
2011-10-25 10:37 ` [PATCH 4/7] ath6kl: Add new functions to handle wow suspend/resume operations rmani
2011-10-28 12:31 ` Kalle Valo [this message]
2011-10-31 9:53 ` Raja Mani
2011-10-25 10:37 ` [PATCH 5/7] ath6kl: Invoke wow suspend/resume calls during PM operations rmani
2011-10-28 13:15 ` Kalle Valo
2011-10-31 9:54 ` Raja Mani
2011-10-31 13:16 ` Kalle Valo
2011-10-28 13:21 ` Kalle Valo
2011-10-31 9:54 ` Raja Mani
2011-10-31 13:29 ` Kalle Valo
2011-10-25 10:37 ` [PATCH 6/7] ath6kl: Perform WOW resume in RX path in case of SDIO IRQ wakeup rmani
2011-10-28 13:18 ` Kalle Valo
2011-10-31 9:55 ` Raja Mani
2011-10-31 13:03 ` Kalle Valo
2011-10-25 10:37 ` [PATCH 7/7] ath6kl: Expose ath6kl wow capabilities to cfg layer rmani
2011-10-28 11:58 ` [PATCH 0/7] ath6kl: Add WOW support Kalle Valo
2011-10-31 9:55 ` Raja Mani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAAA08F.5070905@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).