Re: [wireless-next PATCH 4/5] wifi: Warn if cannot add station debugfs entries.

[Ben Greear <greearb@candelatech.com>]

On 10/28/2011 01:13 AM, Johannes Berg wrote:
> On Thu, 2011-10-27 at 22:11 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>> ---
>> :100644 100644 c5f3417... 1ceec86... M	net/mac80211/debugfs_sta.c
>>   net/mac80211/debugfs_sta.c |   10 ++++++++--
>>   1 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
>> index c5f3417..1ceec86 100644
>> --- a/net/mac80211/debugfs_sta.c
>> +++ b/net/mac80211/debugfs_sta.c
>> @@ -337,8 +337,11 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
>>
>>   	sta->debugfs.add_has_run = true;
>>
>> -	if (!stations_dir)
>> +	if (!stations_dir) {
>> +		printk(KERN_DEBUG "%s: sta_debugfs_add: stations_dir is NULL\n",
>> +			sta->sdata->name);
>>   		return;
>> +	}
>
> I honestly don't see any point in this.

Ok, I wasn't sure if this was wanted, so please just
drop it.  I did see a case where the debugfs files didn't
exist, and was trying to figure out why..but never reproduced
the problem after this printk was in, so not sure if this
was the issue or not.

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com