From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [wireless-next PATCH 1/5] mac80211: Support forcing station to disable 11n.
Date: Fri, 04 Nov 2011 09:11:39 -0700 [thread overview]
Message-ID: <4EB40EBB.9010402@candelatech.com> (raw)
In-Reply-To: <1320417771.3969.90.camel@jlt3.sipsolutions.net>
On 11/04/2011 07:42 AM, Johannes Berg wrote:
> On Thu, 2011-11-03 at 11:17 -0700, Ben Greear wrote:
>
>> So back to the capabilities flag like I added in the -v2 patch?
>> Do you want one flag for each thing (set-mcs, disable-ht,
>> disable-ht40, set-mpdu, set-msdu), or maybe one flag for all of
>> this: set-ht-cap
>
> I think maybe a single one would be sufficient, but you'd still have no
> way of knowing what is actually supported for changing. Maybe you could
> advertise an ht_mask of things that can be changed?
That seems feasible, though it still won't help with the valid ranges
for mpdu-density, for instance.
How about if I add some way to query this, but leave the code loose
in that it won't fail if someone tries to set a value that isn't
supported. That way, user-space can be lazy if it wants, but
can also get the details if it cares.
To get this info, I'm going to have to add a new driver API, as far
as I can tell, and I only have the ability to deal with ath9k, so
that will be the only driver that reports the mask. Of course,
others could modify their drivers as they wish.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-11-04 16:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 5:11 [wireless-next PATCH 1/5] mac80211: Support forcing station to disable 11n greearb
2011-10-28 5:11 ` [wireless-next PATCH 2/5] wifi: Support disabling ht40 greearb
2011-10-28 8:09 ` Johannes Berg
2011-10-28 16:25 ` Ben Greear
2011-10-28 5:11 ` [wireless-next PATCH 3/5] wifi: Allow overriding some HT information greearb
2011-10-28 8:12 ` Johannes Berg
2011-10-28 16:33 ` Ben Greear
2011-11-02 8:13 ` Johannes Berg
2011-11-02 16:59 ` Ben Greear
2011-11-02 17:49 ` Johannes Berg
2011-11-02 18:03 ` Ben Greear
2011-11-03 8:32 ` Johannes Berg
2011-10-28 5:11 ` [wireless-next PATCH 4/5] wifi: Warn if cannot add station debugfs entries greearb
2011-10-28 8:13 ` Johannes Berg
2011-10-28 16:13 ` Ben Greear
2011-10-28 5:11 ` [wireless-next PATCH 5/5] wifi-debugfs: Fix AMSDU rate printout greearb
2011-10-28 8:13 ` Johannes Berg
2011-11-17 17:49 ` Ben Greear
2011-11-17 18:03 ` John W. Linville
2011-10-28 5:15 ` [wireless-next PATCH 1/5] mac80211: Support forcing station to disable 11n Ben Greear
2011-10-28 8:08 ` Johannes Berg
2011-10-28 16:24 ` Ben Greear
2011-11-02 7:56 ` Johannes Berg
2011-11-02 16:37 ` Ben Greear
2011-10-28 18:55 ` Ben Greear
2011-11-02 7:53 ` Johannes Berg
2011-11-02 16:34 ` Ben Greear
2011-11-02 17:51 ` Johannes Berg
2011-11-03 6:04 ` Ben Greear
2011-11-03 8:30 ` Johannes Berg
2011-11-03 18:17 ` Ben Greear
2011-11-04 14:42 ` Johannes Berg
2011-11-04 16:11 ` Ben Greear [this message]
2011-11-04 16:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB40EBB.9010402@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).