From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Raja Mani <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 00/11] ath6kl: Add WOW support
Date: Mon, 7 Nov 2011 23:02:00 +0200 [thread overview]
Message-ID: <4EB84748.7090302@qca.qualcomm.com> (raw)
In-Reply-To: <1320643547-3578-1-git-send-email-rmani@qca.qualcomm.com>
On 11/07/2011 07:25 AM, Raja Mani wrote:
> Version 2 patch set is tested on Qualcomm MSM board and
> takes care most of the review comments given by Kalle.
>
> V2 changes:
> * WOW mode selection logic is moved to HIF layer, earlier it was implemented in CFG i/f layer.
> * Individual parameters are used in the functions instead of struct as a parameter.
> * Unused one extra byte is removed in struct wmi_add_wow_pattern_cmd.
> * Used ar->state for WOW state handling and separate WOW state handling is removed.
> * host sdio irq wake up capability is checked before entering into WOW suspend mode.
> * Empty commit logs are avoided. :-)
> * No error is reported from Sparse.
> * Rebased to multi vif implementation.
>
> and other minor corrections.
>
> Using these patch set, WOW patterns can be controlled and configured via iw command.
> Please refer iw help menu for more details.
>
> Limitations:
> * Optional bytes can't be specified while configuring WOW patterns from iw command.
> This is due to the limitation in the firmware.
>
> * Pattern byte matching will always happen from the first byte of received packet.
> This is the limitation in the recent "iw" command (It doesn't take the pattern
> offset where to start pattern matching in the received packets as of now).
Thanks, patchset looks really good now. There were two things I didn't
like, the check_wow() call in RX path and locking for
ath6kl_wmi_relinquish_implicit_pstream_credits(). But we can fix those
later.
All 11 patches applied. I did a couple of minor changes, I'll send a
separate email describing those.
Kalle
prev parent reply other threads:[~2011-11-07 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 5:25 [PATCH v2 00/11] ath6kl: Add WOW support Raja Mani
2011-11-07 5:25 ` [PATCH v2 01/11] ath6kl: Add wmi functions to add/delete WOW patterns Raja Mani
2011-11-07 5:25 ` [PATCH v2 02/11] ath6kl: Add wmi functions to configure WOW mode and host sleep mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 03/11] ath6kl: Add WOW suspend/resume implementation Raja Mani
2011-11-07 5:25 ` [PATCH v2 04/11] ath6kl: Include new parameter in suspend path for wowlan Raja Mani
2011-11-07 5:25 ` [PATCH v2 05/11] ath6kl: Add new state for WOW mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 06/11] ath6kl: Move ath6kl_cfg80211_stop() call specific to deep sleep and cut pwr Raja Mani
2011-11-07 5:25 ` [PATCH v2 07/11] ath6kl: Invoke WOW suspend/resume calls during PM operation Raja Mani
2011-11-07 21:03 ` Kalle Valo
2011-11-07 5:25 ` [PATCH v2 08/11] ath6kl: Perform WOW resume in RX path in case of SDIO IRQ wake up Raja Mani
2011-11-07 5:25 ` [PATCH v2 09/11] ath6kl: Expose ath6kl's WOW capabilities to CFG layer Raja Mani
2011-11-07 5:25 ` [PATCH v2 10/11] ath6kl: Remove WARN_ON msg in Suspend path Raja Mani
2011-11-07 21:05 ` Kalle Valo
2011-11-07 5:25 ` [PATCH v2 11/11] ath6kl: Remove few unused WMI stuff Raja Mani
2011-11-07 21:02 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB84748.7090302@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).