From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Raja Mani <rmani@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 07/11] ath6kl: Invoke WOW suspend/resume calls during PM operation
Date: Mon, 7 Nov 2011 23:03:23 +0200 [thread overview]
Message-ID: <4EB8479B.8090705@qca.qualcomm.com> (raw)
In-Reply-To: <1320643547-3578-8-git-send-email-rmani@qca.qualcomm.com>
On 11/07/2011 07:25 AM, Raja Mani wrote:
> Link ath6kl's wow suspend/resume functions with the actual suspend/resume path.
>
> WOW mode is selected when the host sdio controller supports both
> MMC_PM_KEEP_POWER and MMC_PM_WAKE_SDIO_IRQ capabilities.
>
[...]
> @@ -1833,6 +1860,7 @@ int ath6kl_cfg80211_resume(struct ath6kl *ar)
> ath6kl_warn("Failed to boot hw in resume: %d\n", ret);
> return ret;
> }
> + break;
>
> default:
> break;
Good catch, I had missed that break. But when you make small fixes like
this, please also mention that in the commit log.
Kalle
next prev parent reply other threads:[~2011-11-07 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 5:25 [PATCH v2 00/11] ath6kl: Add WOW support Raja Mani
2011-11-07 5:25 ` [PATCH v2 01/11] ath6kl: Add wmi functions to add/delete WOW patterns Raja Mani
2011-11-07 5:25 ` [PATCH v2 02/11] ath6kl: Add wmi functions to configure WOW mode and host sleep mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 03/11] ath6kl: Add WOW suspend/resume implementation Raja Mani
2011-11-07 5:25 ` [PATCH v2 04/11] ath6kl: Include new parameter in suspend path for wowlan Raja Mani
2011-11-07 5:25 ` [PATCH v2 05/11] ath6kl: Add new state for WOW mode Raja Mani
2011-11-07 5:25 ` [PATCH v2 06/11] ath6kl: Move ath6kl_cfg80211_stop() call specific to deep sleep and cut pwr Raja Mani
2011-11-07 5:25 ` [PATCH v2 07/11] ath6kl: Invoke WOW suspend/resume calls during PM operation Raja Mani
2011-11-07 21:03 ` Kalle Valo [this message]
2011-11-07 5:25 ` [PATCH v2 08/11] ath6kl: Perform WOW resume in RX path in case of SDIO IRQ wake up Raja Mani
2011-11-07 5:25 ` [PATCH v2 09/11] ath6kl: Expose ath6kl's WOW capabilities to CFG layer Raja Mani
2011-11-07 5:25 ` [PATCH v2 10/11] ath6kl: Remove WARN_ON msg in Suspend path Raja Mani
2011-11-07 21:05 ` Kalle Valo
2011-11-07 5:25 ` [PATCH v2 11/11] ath6kl: Remove few unused WMI stuff Raja Mani
2011-11-07 21:02 ` [PATCH v2 00/11] ath6kl: Add WOW support Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB8479B.8090705@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).