* New wireless-testing has grown some warnings -- please fix ASAP!
@ 2011-11-09 21:50 John W. Linville
2011-11-09 22:12 ` Johannes Berg
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: John W. Linville @ 2011-11-09 21:50 UTC (permalink / raw)
To: linux-wireless
commit befdbc51cc69c01cd412ad2429960b9c3042f97c is the current
wireless-testing head.
This iteration of wireless-testing seems to have grown some
warnings. Some of them come from a new __must_check annotation of
cfg80211_inform_bss, while others are simply unused or uninitialized
variables. In any case, I would prefer not to see them.
Please check the wireless-testing build and attempt to squash any
warnings that can be reasonably squashed. Those who do not do so
will be subject to irritated sighs over IRC, drunken emails about
my new DVD rental service, and accusations of making unwanted sexual
advances toward me. You've been warned.
John
---
CC [M] net/wireless/nl80211.o
net/wireless/nl80211.c: In function ‘nl80211_tx_mgmt’:
net/wireless/nl80211.c:5286:8: warning: ‘hdr’ may be used uninitialized in this function
CC [M] drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.o
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c: In function ‘wl_inform_ibss’:
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:2152:21: warning: ignoring return value of ‘cfg80211_inform_bss’, declared with attribute warn_unused_result
CC [M] drivers/net/wireless/libertas/cfg.o
drivers/net/wireless/libertas/cfg.c: In function ‘lbs_ret_scan’:
drivers/net/wireless/libertas/cfg.c:636:24: warning: ignoring return value of ‘cfg80211_inform_bss’, declared with attribute warn_unused_result
drivers/net/wireless/libertas/cfg.c: In function ‘lbs_join_post’:
drivers/net/wireless/libertas/cfg.c:1766:21: warning: ignoring return value of ‘cfg80211_inform_bss’, declared with attribute warn_unused_result
CC [M] drivers/net/wireless/mwifiex/cfg80211.o
drivers/net/wireless/mwifiex/cfg80211.c: In function ‘mwifiex_cfg80211_inform_ibss_bss’:
drivers/net/wireless/mwifiex/cfg80211.c:803:21: warning: ignoring return value of ‘cfg80211_inform_bss’, declared with attribute warn_unused_result
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: New wireless-testing has grown some warnings -- please fix ASAP!
2011-11-09 21:50 New wireless-testing has grown some warnings -- please fix ASAP! John W. Linville
@ 2011-11-09 22:12 ` Johannes Berg
2011-11-09 22:55 ` Bing Zhao
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Johannes Berg @ 2011-11-09 22:12 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On Wed, 2011-11-09 at 16:50 -0500, John W. Linville wrote:
> CC [M] net/wireless/nl80211.o
> net/wireless/nl80211.c: In function ‘nl80211_tx_mgmt’:
> net/wireless/nl80211.c:5286:8: warning: ‘hdr’ may be used uninitialized in this function
Hm, my compiler is smarter than yours ;-)
Not quite sure how to fix this best, I'll figure out something. Thanks
for the heads-up.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: New wireless-testing has grown some warnings -- please fix ASAP!
2011-11-09 21:50 New wireless-testing has grown some warnings -- please fix ASAP! John W. Linville
2011-11-09 22:12 ` Johannes Berg
@ 2011-11-09 22:55 ` Bing Zhao
2011-11-09 23:58 ` Larry Finger
2011-11-10 8:44 ` [PATCH] nl80211: fix compiler warning Johannes Berg
3 siblings, 0 replies; 6+ messages in thread
From: Bing Zhao @ 2011-11-09 22:55 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless@vger.kernel.org
SGkgSm9obiwNCg0KPiAgIENDIFtNXSAgZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC9jZmc4
MDIxMS5vDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvY2ZnODAyMTEuYzogSW4gZnVu
Y3Rpb24g4oCYbXdpZmlleF9jZmc4MDIxMV9pbmZvcm1faWJzc19ic3PigJk6DQo+IGRyaXZlcnMv
bmV0L3dpcmVsZXNzL213aWZpZXgvY2ZnODAyMTEuYzo4MDM6MjE6IHdhcm5pbmc6IGlnbm9yaW5n
IHJldHVybiB2YWx1ZSBvZg0KPiDigJhjZmc4MDIxMV9pbmZvcm1fYnNz4oCZLCBkZWNsYXJlZCB3
aXRoIGF0dHJpYnV0ZSB3YXJuX3VudXNlZF9yZXN1bHQNCg0KVGhlIFtQQVRDSCA3LzddIEkgc2Vu
dCB5ZXN0ZXJkYXkgKGNvcGllZCAmIHBhc3RlZCBiZWxvdykgZml4ZWQgdGhlIHdhcm5pbmcgaW4g
bXdpZmlleC4NCg0KVGhhbmtzLA0KQmluZw0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K
RnJvbTogQmluZyBaaGFvIFttYWlsdG86YnpoYW9AbWFydmVsbC5jb21dIA0KU2VudDogTW9uZGF5
LCBOb3ZlbWJlciAwNywgMjAxMSA5OjQxIFBNDQpUbzogbGludXgtd2lyZWxlc3NAdmdlci5rZXJu
ZWwub3JnDQpDYzogSm9obiBXLiBMaW52aWxsZTsgQW1pdGt1bWFyIEthcndhcjsgS2lyYW4gRGl2
ZWthcjsgWW9nZXNoIFBvd2FyOyBGcmFuayBIdWFuZzsgQmluZyBaaGFvOyBKb2hhbm5lcyBCZXJn
DQpTdWJqZWN0OiBbUEFUQ0ggNy83XSBtd2lmaWV4OiByZWxlYXNlIGJzcyBzdHJ1Y3R1cmUgcmV0
dXJuZWQgYnkgY2ZnODAyMTFfaW5mb3JtX2JzcygpDQoNCkZyb206IEFtaXRrdW1hciBLYXJ3YXIg
PGFrYXJ3YXJAbWFydmVsbC5jb20+DQoNCkZvbGxvd2luZyBjb21waWxhdGlvbiB3YXJuaW5nIGlz
IGZpeGVkIGJ5IHJlbGVhc2luZyByZWZlcmVuY2VkIEJTUw0Kc3RydWN0dXJlIHJldHVybmVkIGJ5
IGNmZzgwMjExX2luZm9ybV9ic3MoKS4NCg0KIndhcm5pbmc6IGlnbm9yaW5nIHJldHVybiB2YWx1
ZSBvZiBjZmc4MDIxMV9pbmZvcm1fYnNzLA0KZGVjbGFyZWQgd2l0aCBhdHRyaWJ1dGUgd2Fybl91
bnVzZWRfcmVzdWx0Ig0KDQpDYzogSm9oYW5uZXMgQmVyZyA8am9oYW5uZXMuYmVyZ0BpbnRlbC5j
b20+DQpTaWduZWQtb2ZmLWJ5OiBBbWl0a3VtYXIgS2Fyd2FyIDxha2Fyd2FyQG1hcnZlbGwuY29t
Pg0KU2lnbmVkLW9mZi1ieTogQmluZyBaaGFvIDxiemhhb0BtYXJ2ZWxsLmNvbT4NCi0tLQ0KVGhp
cyBwYXRjaCBmaXhlcyB0aGUgYnVnIG1lbnRpb25lZCBieSBKb2hhbm5lcyBCZXJnOg0KU2VlICJb
UEFUQ0hdIGNmZzgwMjExOiBhbm5vdGF0ZSBjZmc4MDIxMV9pbmZvcm1fYnNzIg0KDQogZHJpdmVy
cy9uZXQvd2lyZWxlc3MvbXdpZmlleC9jZmc4MDIxMS5jIHwgICAgNCArKystDQogZHJpdmVycy9u
ZXQvd2lyZWxlc3MvbXdpZmlleC9zY2FuLmMgICAgIHwgICAgMSArDQogMiBmaWxlcyBjaGFuZ2Vk
LCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJz
L25ldC93aXJlbGVzcy9td2lmaWV4L2NmZzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9t
d2lmaWV4L2NmZzgwMjExLmMNCmluZGV4IDQ2MmM3MTAuLmU5YWI5YTMgMTAwNjQ0DQotLS0gYS9k
cml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L2NmZzgwMjExLmMNCisrKyBiL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL213aWZpZXgvY2ZnODAyMTEuYw0KQEAgLTc4MCw2ICs3ODAsNyBAQCBzdGF0aWMg
aW50IG13aWZpZXhfY2ZnODAyMTFfaW5mb3JtX2lic3NfYnNzKHN0cnVjdCBtd2lmaWV4X3ByaXZh
dGUgKnByaXYpDQogew0KIAlzdHJ1Y3QgaWVlZTgwMjExX2NoYW5uZWwgKmNoYW47DQogCXN0cnVj
dCBtd2lmaWV4X2Jzc19pbmZvIGJzc19pbmZvOw0KKwlzdHJ1Y3QgY2ZnODAyMTFfYnNzICpic3M7
DQogCWludCBpZV9sZW47DQogCXU4IGllX2J1ZltJRUVFODAyMTFfTUFYX1NTSURfTEVOICsgc2l6
ZW9mKHN0cnVjdCBpZWVlX3R5cGVzX2hlYWRlcildOw0KIAllbnVtIGllZWU4MDIxMV9iYW5kIGJh
bmQ7DQpAQCAtODAwLDkgKzgwMSwxMCBAQCBzdGF0aWMgaW50IG13aWZpZXhfY2ZnODAyMTFfaW5m
b3JtX2lic3NfYnNzKHN0cnVjdCBtd2lmaWV4X3ByaXZhdGUgKnByaXYpDQogCQkJaWVlZTgwMjEx
X2NoYW5uZWxfdG9fZnJlcXVlbmN5KGJzc19pbmZvLmJzc19jaGFuLA0KIAkJCQkJCSAgICAgICBi
YW5kKSk7DQogDQotCWNmZzgwMjExX2luZm9ybV9ic3MocHJpdi0+d2Rldi0+d2lwaHksIGNoYW4s
DQorCWJzcyA9IGNmZzgwMjExX2luZm9ybV9ic3MocHJpdi0+d2Rldi0+d2lwaHksIGNoYW4sDQog
CQlic3NfaW5mby5ic3NpZCwgMCwgV0xBTl9DQVBBQklMSVRZX0lCU1MsDQogCQkwLCBpZV9idWYs
IGllX2xlbiwgMCwgR0ZQX0tFUk5FTCk7DQorCWNmZzgwMjExX3B1dF9ic3MoYnNzKTsNCiAJbWVt
Y3B5KHByaXYtPmNmZ19ic3NpZCwgYnNzX2luZm8uYnNzaWQsIEVUSF9BTEVOKTsNCiANCiAJcmV0
dXJuIDA7DQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC9zY2FuLmMg
Yi9kcml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L3NjYW4uYw0KaW5kZXggYzY1MGU2MC4uOGEx
OGJjYyAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvc2Nhbi5jDQor
KysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L3NjYW4uYw0KQEAgLTE3NjAsNiArMTc2
MCw3IEBAIGludCBtd2lmaWV4X3JldF84MDJfMTFfc2NhbihzdHJ1Y3QgbXdpZmlleF9wcml2YXRl
ICpwcml2LA0KIAkJCQkJICAgICAgY2FwX2luZm9fYml0bWFwLCBiZWFjb25fcGVyaW9kLA0KIAkJ
CQkJICAgICAgaWVfYnVmLCBpZV9sZW4sIHJzc2ksIEdGUF9LRVJORUwpOw0KIAkJCQkqKHU4ICop
YnNzLT5wcml2ID0gYmFuZDsNCisJCQkJY2ZnODAyMTFfcHV0X2Jzcyhic3MpOw0KIA0KIAkJCQlp
ZiAocHJpdi0+bWVkaWFfY29ubmVjdGVkICYmICFtZW1jbXAoYnNzaWQsDQogCQkJCQlwcml2LT5j
dXJyX2Jzc19wYXJhbXMuYnNzX2Rlc2NyaXB0b3INCi0tIA0KMS43LjAuMg0K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New wireless-testing has grown some warnings -- please fix ASAP!
2011-11-09 21:50 New wireless-testing has grown some warnings -- please fix ASAP! John W. Linville
2011-11-09 22:12 ` Johannes Berg
2011-11-09 22:55 ` Bing Zhao
@ 2011-11-09 23:58 ` Larry Finger
2011-11-10 15:01 ` John W. Linville
2011-11-10 8:44 ` [PATCH] nl80211: fix compiler warning Johannes Berg
3 siblings, 1 reply; 6+ messages in thread
From: Larry Finger @ 2011-11-09 23:58 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On 11/09/2011 03:50 PM, John W. Linville wrote:
> commit befdbc51cc69c01cd412ad2429960b9c3042f97c is the current
> wireless-testing head.
>
> This iteration of wireless-testing seems to have grown some
> warnings. Some of them come from a new __must_check annotation of
> cfg80211_inform_bss, while others are simply unused or uninitialized
> variables. In any case, I would prefer not to see them.
>
> Please check the wireless-testing build and attempt to squash any
> warnings that can be reasonably squashed. Those who do not do so
> will be subject to irritated sighs over IRC, drunken emails about
> my new DVD rental service, and accusations of making unwanted sexual
> advances toward me. You've been warned.
>
> John
For the record, what compiler are you using?
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New wireless-testing has grown some warnings -- please fix ASAP!
2011-11-09 23:58 ` Larry Finger
@ 2011-11-10 15:01 ` John W. Linville
0 siblings, 0 replies; 6+ messages in thread
From: John W. Linville @ 2011-11-10 15:01 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless
On Wed, Nov 09, 2011 at 05:58:10PM -0600, Larry Finger wrote:
> On 11/09/2011 03:50 PM, John W. Linville wrote:
> >commit befdbc51cc69c01cd412ad2429960b9c3042f97c is the current
> >wireless-testing head.
> >
> >This iteration of wireless-testing seems to have grown some
> >warnings. Some of them come from a new __must_check annotation of
> >cfg80211_inform_bss, while others are simply unused or uninitialized
> >variables. In any case, I would prefer not to see them.
> >
> >Please check the wireless-testing build and attempt to squash any
> >warnings that can be reasonably squashed. Those who do not do so
> >will be subject to irritated sighs over IRC, drunken emails about
> >my new DVD rental service, and accusations of making unwanted sexual
> >advances toward me. You've been warned.
> >
> >John
>
> For the record, what compiler are you using?
[linville-8530p.local]:> gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.5.1/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared
--enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,lto --enable-plugin --enable-java-awt=gtk --disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre --enable-libgcj-multifile
--enable-java-maintainer-mode --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.5.1 20100924 (Red Hat 4.5.1-4) (GCC)
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nl80211: fix compiler warning
2011-11-09 21:50 New wireless-testing has grown some warnings -- please fix ASAP! John W. Linville
` (2 preceding siblings ...)
2011-11-09 23:58 ` Larry Finger
@ 2011-11-10 8:44 ` Johannes Berg
3 siblings, 0 replies; 6+ messages in thread
From: Johannes Berg @ 2011-11-10 8:44 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
From: Johannes Berg <johannes.berg@intel.com>
John reported the following warning:
net/wireless/nl80211.c: In function ‘nl80211_tx_mgmt’:
net/wireless/nl80211.c:5286:8: warning: ‘hdr’ may be used uninitialized in this function
Evidently, his version of gcc isn't able to see that
when "msg" is initialized, "hdr" must also be. My
gcc, 4.6.1, can actually see that and doesn't warn.
Simply initialize the variable to NULL. That means
if the compiler was ever right we'll crash though so
isn't really optimal since it may hide warnings from
the compiler when somebody modifies this code in the
future.
Reported-by: John Linville <linville@tuxdriver.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/wireless/nl80211.c 2011-11-10 09:36:08.000000000 +0100
+++ b/net/wireless/nl80211.c 2011-11-10 09:42:15.000000000 +0100
@@ -5283,7 +5283,7 @@ static int nl80211_tx_mgmt(struct sk_buf
bool channel_type_valid = false;
u32 freq;
int err;
- void *hdr;
+ void *hdr = NULL;
u64 cookie;
struct sk_buff *msg = NULL;
unsigned int wait = 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-10 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 21:50 New wireless-testing has grown some warnings -- please fix ASAP! John W. Linville
2011-11-09 22:12 ` Johannes Berg
2011-11-09 22:55 ` Bing Zhao
2011-11-09 23:58 ` Larry Finger
2011-11-10 15:01 ` John W. Linville
2011-11-10 8:44 ` [PATCH] nl80211: fix compiler warning Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).