* [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG
@ 2011-11-15 8:44 Raja Mani
2011-11-16 8:42 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Raja Mani @ 2011-11-15 8:44 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Raja Mani
Connect control flag CONNECT_WPS_FLAG has to be cleared
by default even if the driver receives zero length IE
from CFG.
Otherwise this flag would be always set after WPS exchange
which would lead wpa_supplicant to fail to connect with
the received WPS credentials. This issue is observed only
in OPEN security.
Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 6da5c9e..b99cdc9 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -427,7 +427,8 @@ static int ath6kl_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
status = ath6kl_set_assoc_req_ies(vif, sme->ie, sme->ie_len);
if (status)
return status;
- }
+ } else
+ ar->connect_ctrl_flags &= ~CONNECT_WPS_FLAG;
if (test_bit(CONNECTED, &vif->flags) &&
vif->ssid_len == sme->ssid_len &&
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG
2011-11-15 8:44 [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG Raja Mani
@ 2011-11-16 8:42 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2011-11-16 8:42 UTC (permalink / raw)
To: Raja Mani; +Cc: linux-wireless
On 11/15/2011 10:44 AM, Raja Mani wrote:
> Connect control flag CONNECT_WPS_FLAG has to be cleared
> by default even if the driver receives zero length IE
> from CFG.
>
> Otherwise this flag would be always set after WPS exchange
> which would lead wpa_supplicant to fail to connect with
> the received WPS credentials. This issue is observed only
> in OPEN security.
Thanks, applied. But I did a s/CFG/cfg80211/ in the commit log.
Kalle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-16 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-15 8:44 [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG Raja Mani
2011-11-16 8:42 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).