[PATCH] ath6kl: Fix AP mode operation after interface down/up

[PATCH] ath6kl: Fix AP mode operation after interface down/up

[Vasanthakumar Thiagarajan]

When operating AP interface is brough down the mode is reset to
STA. This STA will be reconfigured into AP mode when the interface
is brought up again. This sequence will be successful only when
change_virtual_intf() returns with no error, but there is a
check in this callback which does the type change only when
that interface is active. This callback does nothing more
than saving the new interface type to vif and wdev, so the
sanity check for interface state and wmi state is not necessary.
This makes the AP interface functional again after interface down/up.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 08708bd..733cff0 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -1353,9 +1353,6 @@ static int ath6kl_cfg80211_change_iface(struct wiphy *wiphy,
 
 	ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "%s: type %u\n", __func__, type);
 
-	if (!ath6kl_cfg80211_ready(vif))
-		return -EIO;
-
 	switch (type) {
 	case NL80211_IFTYPE_STATION:
 		vif->next_mode = INFRA_NETWORK;
-- 
1.7.0.4

Re: [PATCH] ath6kl: Fix AP mode operation after interface down/up

[Kalle Valo]

On 11/16/2011 09:51 AM, Vasanthakumar Thiagarajan wrote:
> When operating AP interface is brough down the mode is reset to
> STA. This STA will be reconfigured into AP mode when the interface
> is brought up again. This sequence will be successful only when
> change_virtual_intf() returns with no error, but there is a
> check in this callback which does the type change only when
> that interface is active. This callback does nothing more
> than saving the new interface type to vif and wdev, so the
> sanity check for interface state and wmi state is not necessary.
> This makes the AP interface functional again after interface down/up.
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>

Thanks, applied.

Kalle