[PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Daniel Kuehn]

from: Daniel Kuehn <daniel@kuehn.se>

Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support
default y helps those porting a config from 2.6 kernel series
from getting "non-functional" wireless drivers with 3.x kernel series.

Signed-off-by: Daniel Kuehn <daniel@kuehn.se>
---
 drivers/net/wireless/ath/ath9k/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig
b/drivers/net/wireless/ath/ath9k/Kconfig index d9c08c6..7b4c074 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -25,6 +25,7 @@ config ATH9K
 
 config ATH9K_PCI
 	bool "Atheros ath9k PCI/PCIe bus support"
+	default y
 	depends on ATH9K && PCI
 	---help---
 	  This option enables the PCI bus support in ath9k.
-- 
1.7.7.2

Re: [PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Gabor Juhos]

2011.11.09. 23:57 keltezéssel, Daniel Kuehn írta:
> from: Daniel Kuehn <daniel@kuehn.se>
> 
> Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support
> default y helps those porting a config from 2.6 kernel series
> from getting "non-functional" wireless drivers with 3.x kernel series.
> 
> Signed-off-by: Daniel Kuehn <daniel@kuehn.se>

The option was enabled in the past but it has been removed a few months ago by
the following commit:

commit 64bd0821a3b66c3307d7a4ee5523e3e35ec2df0e
Author: Tao Ma <boyu.mt@taobao.com>
Date:   Wed May 25 09:44:05 2011 +0800

    wireless: Default to 'n' for 2 new added devices in Kconfig.

    We make oldconfig every time when a new kernel arrives, but
    if we don't have such a device(I guess this is the most common
    case for a new device), the default value should be 'n' so
    that the kernel size we build doesn't grow up too much quickly.
    For anyone who has the device, it is OK for them to turn it on
    by themselves.

    Cc: "John W. Linville" <linville@tuxdriver.com>
    Cc: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: Tao Ma <boyu.mt@taobao.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>


In my opinion it should not be added again.

Regards,
Gabor

Re: [PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Daniel Kuehn]

[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]

On Thu, 17 Nov 2011 16:13:53 +0100
Gabor Juhos <juhosg@openwrt.org> wrote:

> 2011.11.09. 23:57 keltezéssel, Daniel Kuehn írta:
> > from: Daniel Kuehn <daniel@kuehn.se>
> > 
> > Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support
> > default y helps those porting a config from 2.6 kernel series
> > from getting "non-functional" wireless drivers with 3.x kernel series.
> > 
> > Signed-off-by: Daniel Kuehn <daniel@kuehn.se>
> 
> The option was enabled in the past but it has been removed a few months ago by
> the following commit:
> 
> commit 64bd0821a3b66c3307d7a4ee5523e3e35ec2df0e
> Author: Tao Ma <boyu.mt@taobao.com>
> Date:   Wed May 25 09:44:05 2011 +0800
> 
>     wireless: Default to 'n' for 2 new added devices in Kconfig.
> 
>     We make oldconfig every time when a new kernel arrives, but
>     if we don't have such a device(I guess this is the most common
>     case for a new device), the default value should be 'n' so
>     that the kernel size we build doesn't grow up too much quickly.
>     For anyone who has the device, it is OK for them to turn it on
>     by themselves.
> 
>     Cc: "John W. Linville" <linville@tuxdriver.com>
>     Cc: Johannes Berg <johannes@sipsolutions.net>
>     Signed-off-by: Tao Ma <boyu.mt@taobao.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> 
> In my opinion it should not be added again.

I agree with you there if it was removed before, maybe then only the help
section of ath9k should be changed to say that you have to enable either
PCI/PCIe or AHB support for it to work?

Because it doesn't seem to be possible to make it choose that option and still
make it removable IF ath9k is chosen.
It seems you either need to default it to y (with default y) or make it
unremovable if ath9k is selected (with select ATH9K_PCI for ATH9K).

> 
> Regards,
> Gabor

Kind regards,
Daniel Kuehn

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Gabor Juhos]

2011.11.17. 16:39 keltezéssel, Daniel Kuehn írta:

> I agree with you there if it was removed before, maybe then only the help 
> section of ath9k should be changed to say that you have to enable either 
> PCI/PCIe or AHB support for it to work?

Yes, adding a comment there would make sense, although that does not prevent
to build ath9k without bus support.

-Gabor

Re: [PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Daniel Kuehn]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Thu, 17 Nov 2011 19:44:59 +0100
Gabor Juhos <juhosg@openwrt.org> wrote:

> 2011.11.17. 16:39 keltezéssel, Daniel Kuehn írta:
> 
> > I agree with you there if it was removed before, maybe then only the help 
> > section of ath9k should be changed to say that you have to enable either 
> > PCI/PCIe or AHB support for it to work?
> 
> Yes, adding a comment there would make sense, although that does not prevent
> to build ath9k without bus support.

Yeah, that is the initial problem I found that I wanted to try and patch, but
seeing as it only stands between either always enabling it, or forcing one or
the other bus always on if you choose ath9k I don't know what else could be
done except note in the help that you also need to enable bus support.

I haven't poked around that much with Kconfig but it clearly seems like there
isn't a way to default select y but make it possible to disable it...

So there doesn't seem to be a clear way to automagically include the most
common bus support for ath9k.

> 
> -Gabor

Kind regards,
Daniel Kuehn

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]