From: Hauke Mehrtens <hauke@hauke-m.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: mcgrof@gmail.com, mcgrof@qca.qualcomm.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] compat: backport kfree_rcu()
Date: Fri, 18 Nov 2011 00:05:05 +0100 [thread overview]
Message-ID: <4EC59321.5000806@hauke-m.de> (raw)
In-Reply-To: <1321568836.3997.53.camel@jlt3.sipsolutions.net>
On 11/17/2011 11:27 PM, Johannes Berg wrote:
> On Thu, 2011-11-17 at 22:23 +0100, Hauke Mehrtens wrote:
>
>> +#undef module_exit
>> +#define module_exit(exitfn) \
>
>> + static inline exitcall_t __exittest(void) \
>> + { return exitfn; } \
>
> This is not necessary since the exitfn() below will already create a
> compile error if you try module_exit(no_such_function).
This check is not needed, I will remove it. We get the code from the
kernel and it should compile. Most of the tests this function does are
also done by our real function.
>
>> + void __exit __exit_compat(void) \
>> + { \
>
> Shouldn't that be static?
Yes it also works when it is static I changed that.
>
> johannes
>
>
Hauke
next prev parent reply other threads:[~2011-11-17 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 21:23 [PATCH 1/3] compat: add support for kernel 3.2 Hauke Mehrtens
2011-11-17 21:23 ` [PATCH 2/3] compat: backport kfree_rcu() Hauke Mehrtens
2011-11-17 22:27 ` Johannes Berg
2011-11-17 23:05 ` Hauke Mehrtens [this message]
2011-11-17 23:05 ` [PATCH v2 " Hauke Mehrtens
2011-11-18 0:31 ` Luis R. Rodriguez
2011-11-17 21:23 ` [PATCH 3/3] compat: backport netdev_features_t Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC59321.5000806@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=mcgrof@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).