Re: [PATCH 2/2] compat: implement dummy security_sk_clone

[Hauke Mehrtens <hauke@hauke-m.de>]

On 11/17/2011 01:39 AM, John W. Linville wrote:
> This has been defined in include/linux/security.h for some time, but was
> only given an EXPORT_SYMBOL for 3.2.  Add a compat_* definition to avoid
> breaking the module load with an undefined symbol.
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
>  include/linux/compat-3.2.h |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/compat-3.2.h b/include/linux/compat-3.2.h
> index ceaaecc..08f102f 100644
> --- a/include/linux/compat-3.2.h
> +++ b/include/linux/compat-3.2.h
> @@ -72,6 +72,17 @@ static inline char *hex_byte_pack(char *buf, u8 byte)
>  	return buf;
>  }
>  
> +/*
> + * This has been defined in include/linux/security.h for some time, but was
> + * only given an EXPORT_SYMBOL for 3.2.  Add a compat_* definition to avoid
> + * breaking the compile.
> + */
> +#define security_sk_clone(a, b) compat_security_sk_clone(a, b)
> +
> +static inline void security_sk_clone(const struct sock *sk, struct sock *newsk)
> +{
> +}
> +
>  #endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(3,2,0)) */
>  
>  #endif /* LINUX_3_2_COMPAT_H */

Hi,

security_sk_clone gets also exported in Linux-3.1 so this should move to
include/linux/compat-3.1.h. 3.1-rcX did not contain this fix, but I hope
nobody is using this any more.

Hauke

$ git tag --contains 6230c9b4f8957c8938ee4cf2d03166d3c2dc89de
v3.1
v3.1.1
v3.2-rc1
v3.2-rc2