Re: [PATCH v10 2/2] mac80211: Support ht-cap over-rides.

[Ben Greear <greearb@candelatech.com>]

On 11/18/2011 12:30 PM, Johannes Berg wrote:
> On Fri, 2011-11-18 at 11:32 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This implements ht-cap over-rides for mac80211 drivers.
>> HT may be disabled, making an /a/b/g/n station act like an
>> a/b/g station.  HT40 may be disabled forcing the station to
>> be HT20 even if the AP and local hardware support HT40.
>>
>> MAX-AMSDU may be disabled.
>> AMPDU-Density may be increased.
>> AMPDU-Factor may be decreased.
>>
>> This has been successfully tested with ath9k using patched
>> wpa_supplicant and iw.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>> ---
>>
>> v10:
>>   *  Add check in ieee80211_apply_htcap_overrides to make
>>      sure we are type NL80211_IFTYPE_STATION.
>>
>>   *  Memset u.mgd.ht_capa and ht_capa_mask to 0 in
>>      ieee80211_set_disassoc to make sure we do not try to
>>      use stale data.
>>
>>   *  Add cpu_to_le16 when dealing with u.mgd.ht_capa*
>>      Appears to make no change on x86, but should help
>>      with certain other platforms.
>>
>>   *  Addressed other issues brought up in review of v9.
>
> Thanks. I haven't tested it, but see no obvious bugs. :-)

Well, feels like progress!

If you actually want to enable/view the new features, you'll want
to patch hostap and iw.  You could use my trees if you want, though
they have some extra stuff and the ht-caps logic needs the cpu_to_le16
changes and probably a bit of other cleanup at the moment.

https://github.com/greearb/hostap-ct
https://github.com/greearb/iw-ct

I'll post some clean iw and hostap patches later today if all goes well.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com