* [patch] ath6kl: unlock if ath6kl_cfg80211_connect() fails
@ 2011-11-18 14:09 Dan Carpenter
2011-11-21 16:21 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-18 14:09 UTC (permalink / raw)
To: Kalle Valo, Kevin Fang; +Cc: John W. Linville, linux-wireless, kernel-janitors
There is an unlock missing on this error path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 0252604..5bb4060 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -427,8 +427,10 @@ static int ath6kl_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
if (sme->ie && (sme->ie_len > 0)) {
status = ath6kl_set_assoc_req_ies(vif, sme->ie, sme->ie_len);
- if (status)
+ if (status) {
+ up(&ar->sem);
return status;
+ }
}
if (test_bit(CONNECTED, &vif->flags) &&
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ath6kl: unlock if ath6kl_cfg80211_connect() fails
2011-11-18 14:09 [patch] ath6kl: unlock if ath6kl_cfg80211_connect() fails Dan Carpenter
@ 2011-11-21 16:21 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2011-11-21 16:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kevin Fang, John W. Linville, linux-wireless, kernel-janitors
On 11/18/2011 04:09 PM, Dan Carpenter wrote:
> There is an unlock missing on this error path.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to ath6kl.git. There was a conflict but that was easy to
fix.
Kalle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-21 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 14:09 [patch] ath6kl: unlock if ath6kl_cfg80211_connect() fails Dan Carpenter
2011-11-21 16:21 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).