From: Felix Fietkau <nbd@openwrt.org>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
linux-wireless@vger.kernel.org,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
Balasubramanian senthilkumar <senthilb@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Vivek Natarajan <nataraja@qca.qualcomm.com>,
ath9k-devel@lists.ath9k.org, Wilson Tsao <wtsao@qca.qualcomm.com>
Subject: Re: [PATCH 16/18] ath9k: make ath_reset non-static
Date: Wed, 23 Nov 2011 22:32:52 +0700 [thread overview]
Message-ID: <4ECD1224.3070900@openwrt.org> (raw)
In-Reply-To: <4ECD0ECC.2060101@qca.qualcomm.com>
On 2011-11-23 10:18 PM, Mohammed Shafi Shajakhan wrote:
> Hi Felix,
>
> thanks for your review.
> On Wednesday 23 November 2011 07:59 PM, Felix Fietkau wrote:
>> On 2011-11-22 11:22 PM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>>
>>> to be used by MCI specific changes
>>>
>>> Cc: Wilson Tsao<wtsao@qca.qualcomm.com>
>>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>>> Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> NACK. ath_reset can no longer be called in tasklet context (which you
>> seem to be doing in the next patch).
>> Replace your ath_reset() call with:
>> ieee80211_queue_work(sc->hw,&sc->hw_reset_work);
>>
>> - Felix
>
> just like in ath9k_flush, i like to have the chip reset immediately
> rather than queuing at as a work.
> in chip reset we have:
> *we have BT calibration
> *sync up with BT state
> *2g_5g change
> *LNA transfer
> and few other things
>
> when BT asks for calibration i understand we have to immediately give
> preference to it.
> please let me know if i had missed something and also if queuing
> ath_reset actually helps us in some way.
> i will revert this back once i test queue_work does no harm.
Doing reset from tasklet context created several nasty stability issues
that were hard to track down, and the potential gain from doing reset
'immediately' that way is purely theoretical. Resets should be rare in
normal operation, as they're also expensive.
The main problem when running reset from a tasklet is that there is no
way of gracefully shutting down ongoing workqueue activity, so the
result of the reset could be that the work items mess up the state right
after the reset is done.
- Felix
next prev parent reply other threads:[~2011-11-23 15:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 16:22 [PATCH 00/18] Add support for MCI BT coex Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 01/18] ath9k_hw: add definitions to support MCI h/w code Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 02/18] ath9k_hw: add GPIO output MUX related macros Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 03/18] ath9k_hw: Add MCI h/w specific structure Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 04/18] ath9k_hw: initialize MCI parameters Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 05/18] ath9k_hw: Add MCI h/w code and state machine Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 06/18] ath9k: Add MCI interrupt to interrupt mask Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 07/18] ath9k_hw: take care of enabling MCI interrupts Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 08/18] ath9k_hw: check for asynchronous MCI interrupt pending Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 09/18] ath9k_hw: check for MCI interrupt in get_isr Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 10/18] ath9k: add MCI specific definitions and structures Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 11/18] ath9k: Add functions to allocate/free buffers for MCI Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 12/18] ath9k_hw: MCI related changes in chip management Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 13/18] ath9k_hw: MCI related changes in set_reset_reg Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 14/18] ath9k_hw: Add support for MCI WLAN calibration Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 15/18] ath9k_hw: Add MCI related changes in chip reset Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 16/18] ath9k: make ath_reset non-static Mohammed Shafi Shajakhan
2011-11-23 14:29 ` Felix Fietkau
2011-11-23 15:18 ` Mohammed Shafi Shajakhan
2011-11-23 15:32 ` Felix Fietkau [this message]
2011-11-24 6:07 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 17/18] ath9k: MCI state machine based on MCI interrupt Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [PATCH 18/18] ath9k: fix a typo Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECD1224.3070900@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mohammed@qca.qualcomm.com \
--cc=nataraja@qca.qualcomm.com \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
--cc=wtsao@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).